Bug 1360797
| Summary: | Please update to at least 2.0.7 release | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Barry Scott <barry> |
| Component: | GitPython | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 24 | CC: | barry, dennis, ewoud+redhat, ignatenko, lsedlar, puiterwijk |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | GitPython-2.1.1-1.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-28 12:06:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Barry Scott
2016-07-27 13:55:45 UTC
Here's the issue: * GitPython dropped support for Python 2.6 in 2.0.0 * rpkg (and inderectly fedpkg) depend on GitPython * rpkg upstream wants to support Python 2.6 If we update GitPython, we are quite likely breaking an important tool. If we don't, we're stuck with an old library. I'm not sure what is the best way forward. I do not understand your logic. Given that python2.6 is not available on F24 what is the issue? I hope you are not saying that rpkg only support python2.6, surely 2.7 is supported. Barry Rpkg upstream wants to support other systems than F24 that still support 2.6. It indeed does support 2.7 as well as being updated for Python 3. It just isn't ready to drop support for 2.6. I think the claim of python 2.6 support is a not the key issue. It is also not an issue that rpkg want to support old systems, it is surely for them to figure out how to work across a range of dependencies in that case. The issue is this: will rpkg work with GitPython 2.x? Do you know if rpkg break is GitPython 2.x is installed? If it does then rpkg needs to fix any problems by doing a version check against GitPython and use a two code paths. When features where added to GitPython it was done with a lot of care for backwards compatibility. I believe that the python2.6 support being dropped was because of the desire to support python3. Barry Please update to latest GitPython as rpkg is not a blocker. Please see email thread on Fedora Devel list especially the report of all rpkg tests passing against GitPython 2 from Chenxiong Qi on 16 nov 2016. "I've tested GitPython >= 2 with rpkg by running all existent tests, that covers most of the calls to GitPython API. All tests passed, and I don't see an issue. I'm glad to see the upgrade too. I think the upgrade should not be a big issue to rpkg, as there is still GitPython 1.x in EPEL6." Barry I hope to package python-git-up and that needs GitPython >= 2.0.0. Resolving this would help me a lot. Work has started on this. |