Bug 1360985

Summary:	[SNAPSHOT]: The PID for snapd is displayed even after snapd process is killed.
Product:	[Community] GlusterFS	Reporter:	Avra Sengupta <asengupt>
Component:	snapshot	Assignee:	Avra Sengupta <asengupt>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.1	CC:	bugs, rjoseph
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1358244	Environment:
Last Closed:	2016-08-12 09:48:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1358244
Bug Blocks:	1360979

Description Avra Sengupta 2016-07-28 06:11:37 UTC

+++ This bug was initially created as a clone of Bug #1358244 +++

Description of problem:
Even after snapd process is killed, it's older pid continues to be displayed. 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-07-22 02:14:41 EDT ---

REVIEW: http://review.gluster.org/14981 (snapshot/snapd: Don't dispay pid when snapd is offline) posted (#1) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Vijay Bellur on 2016-07-22 22:45:46 EDT ---

REVIEW: http://review.gluster.org/14981 (snapshot/snapd: Don't display pid when snapd is offline) posted (#2) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Vijay Bellur on 2016-07-26 03:55:22 EDT ---

REVIEW: http://review.gluster.org/14981 (snapshot/snapd: Don't display pid when snapd is offline) posted (#3) for review on master by Avra Sengupta (asengupt)

--- Additional comment from Vijay Bellur on 2016-07-27 18:07:26 EDT ---

COMMIT: http://review.gluster.org/14981 committed in master by Jeff Darcy (jdarcy) 
------
commit ec6925a379c7bee071df1638bc2751b266cee346
Author: Avra Sengupta <asengupt>
Date:   Fri Jul 22 11:40:32 2016 +0530

    snapshot/snapd: Don't display pid when snapd is offline
    
    We were previously reading the pidfile, and displaying
    the pid even if snapd daemon is not running. Now to fix
    it, we re-assign pid value to -1, if snapd is offline.
    
    Change-Id: I4baff8d489fe9380061c52aea006db90fa421cd7
    BUG: 1358244
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/14981
    Tested-by: Vijay Bellur <vbellur>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 1 Vijay Bellur 2016-07-28 06:13:06 UTC

REVIEW: http://review.gluster.org/15033 (snapshot/snapd: Don't display pid when snapd is offline) posted (#1) for review on release-3.8 by Avra Sengupta (asengupt)

Comment 2 Vijay Bellur 2016-08-02 06:19:05 UTC

COMMIT: http://review.gluster.org/15033 committed in release-3.8 by Rajesh Joseph (rjoseph) 
------
commit 69029a8e1d9ebc5150a0eeb2b3faa6481c409965
Author: Avra Sengupta <asengupt>
Date:   Fri Jul 22 11:40:32 2016 +0530

    snapshot/snapd: Don't display pid when snapd is offline
    
        Backport of http://review.gluster.org/#/c/14981/
    
    We were previously reading the pidfile, and displaying
    the pid even if snapd daemon is not running. Now to fix
    it, we re-assign pid value to -1, if snapd is offline.
    
    > Reviewed-on: http://review.gluster.org/14981
    > Tested-by: Vijay Bellur <vbellur>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Smoke: Gluster Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Jeff Darcy <jdarcy>
    
    (cherry picked from commit ec6925a379c7bee071df1638bc2751b266cee346)
    
    Change-Id: I4baff8d489fe9380061c52aea006db90fa421cd7
    BUG: 1360985
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/15033
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Rajesh Joseph <rjoseph>

Comment 3 Niels de Vos 2016-08-12 09:48:11 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.2, please open a new bug report.

glusterfs-3.8.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/announce/2016-August/000058.html
[2] https://www.gluster.org/pipermail/gluster-users/