Bug 1360988

Summary:	application JS is not minified
Product:	Red Hat CloudForms Management Engine	Reporter:	Tsai Li Ming <ltsai>
Component:	UI - OPS	Assignee:	Martin Hradil <mhradil>
Status:	CLOSED ERRATA	QA Contact:	Jan Krocil <jkrocil>
Severity:	low	Docs Contact:
Priority:	medium
Version:	5.6.0	CC:	cpelland, dhalasz, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone:	GA	Keywords:	ZStream
Target Release:	5.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ui:usability
Fixed In Version:	5.7.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1374689 (view as bug list)		Environment:
Last Closed:	2017-01-04 12:58:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1374689

Description Tsai Li Ming 2016-07-28 06:17:18 UTC

Description of problem:
./public/assets/application-472f11fa4b21ecfa0f3d6adce02e46d9ac75529950786386f30d0e2b6a791e8c.js is not minified. JS is about 8MB and should be be minified to reduce transfer time. 

Version-Release number of selected component (if applicable):
5.6.0.13.20160624114606_13a9153 

Actual results:
JS is not minified

Expected results:
JS should be minified for production deployment

Additional info:

Comment 6 CFME Bot 2016-09-07 16:42:05 UTC

New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=d40f259f2084f0825338455a51156ca45dd4c2c6

commit d40f259f2084f0825338455a51156ca45dd4c2c6
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Aug 4 13:01:14 2016 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Thu Aug 4 13:01:14 2016 +0000

    appliance build - run evm:compile_assets with the production environment
    
    this enables js & css minification
    
    already being used for upstream builds - https://github.com/ManageIQ/manageiq-appliance-build/blob/master/kickstarts/partials/post/ui_compile.ks.erb#L7
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1360988

 manageiq-appliance-build/lib/tasks/tar_build.rake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 7 CFME Bot 2016-09-07 16:42:10 UTC

New commit detected on cfme_productization/master:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme_productization.git;a=commit;h=10bb05cea8f9afa1e1e512bd4967b7ec64cca840

commit 10bb05cea8f9afa1e1e512bd4967b7ec64cca840
Merge: 30d9baa d40f259
Author:     Dan Clarizio <dclarizi>
AuthorDate: Wed Sep 7 12:36:58 2016 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Wed Sep 7 12:36:58 2016 -0400

    Merge branch 'compile_production_master' into 'master'
    
    appliance build - run evm:compile_assets with the production environment
    
    This enables js & css minification.
    
    already being used for upstream builds - https://github.com/ManageIQ/manageiq-appliance-build/blob/master/kickstarts/partials/post/ui_compile.ks.erb#L7
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1360988
    
    
    Also, without this, the fix for https://bugzilla.redhat.com/show_bug.cgi?id=1333612 (https://github.com/ManageIQ/manageiq/pull/8694) couldn't have done anything downstream..
    
    @simaishi can you verify please?
    
    See merge request !319

 manageiq-appliance-build/lib/tasks/tar_build.rake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 8 Jan Krocil 2016-10-27 08:27:45 UTC

Verified fixed in 5.7.0.7 - 5.7.0.7-beta1.20161025153249_9376fbd.

Comment 10 errata-xmlrpc 2017-01-04 12:58:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0012.html