Bug 1361091

Summary: Policies explorer is recursive, doesn't show policies
Product: Red Hat CloudForms Management Engine Reporter: Beni Paskin-Cherniavsky <cben>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: high Docs Contact:
Priority: high    
Version: 5.6.0CC: cpelland, dajohnso, dmisharo, hkataria, jhardy, jprause, mhradil, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: control:container:ui
Fixed In Version: 5.7.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1362181 (view as bug list) Environment:
Last Closed: 2017-01-11 19:54:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1362181    
Attachments:
Description Flags
screenshot of the problem none

Description Beni Paskin-Cherniavsky 2016-07-28 10:36:16 UTC
Created attachment 1185021 [details]
screenshot of the problem

**Happens on current master AND DARGA.  Requesting Z-stream clone to be blocker.**

Description of problem:
Control -> Explorer -> Policies accordion: explorer expands to infinite recursion, doesn't let you get to policies to see/edit them.

Version-Release number of selected component (if applicable):
darga (810a94fe507f27c5f727fe4df03a0c651e1e5d9e commit), and master.

Steps to Reproduce:
1. Go to Control -> Explorer -> Policies accordion.
2. Try to expand everything e.g. the built-in Container Image policies

Actual results:
See attached screenshot.
"▾ Container Image Control Policies" expands again to:
. Host Control Policies
. Vm Control Policies
...
▸ Container Image Control Policies

clicking the last one expands recursively to the same children, ad infinitum...
(same with compliance)

Expected results:
"▾ Container Image Control Policies" should expand to specific policies:
. Analyse incoming container images
. Schedule compliance after smart state analysis

Additional info:
Right-hand side does list correct children — specific policies, but clicking those doesn't let you open the policy (IIUC it relies on selecting it from explorer).

"Good" news is that it's still possible to add a new policy (standing on "{entity} {Compliance/Control} Policies"), after which the new policy — and other existing policies of this type — appear correctly in the explorer, so you can further edit them.
Fully expanding events under them will then show "Load error" instead of event's actions (https://bugzilla.redhat.com/show_bug.cgi?id=1360818), but you can see/edit actions on right side.

Comment 2 Martin Hradil 2016-07-28 11:54:25 UTC
Taking this one, because while this is a separate issue from https://bugzilla.redhat.com/show_bug.cgi?id=1360818 , the fix for both is the same.. https://github.com/ManageIQ/manageiq/pull/10110

Comment 3 Beni Paskin-Cherniavsky 2016-07-31 08:46:37 UTC
Sorry, forgot to request z-stream clone, setting 5.6.z? now.

Already fixed on master by
https://github.com/ManageIQ/manageiq/pull/10110
and on darga by
https://github.com/ManageIQ/manageiq/pull/10116

Comment 4 Beni Paskin-Cherniavsky 2016-07-31 08:48:21 UTC
*** Bug 1361001 has been marked as a duplicate of this bug. ***

Comment 5 Beni Paskin-Cherniavsky 2016-07-31 09:12:04 UTC
*** Bug 1361215 has been marked as a duplicate of this bug. ***

Comment 6 Pavel Zagalsky 2016-08-01 12:13:42 UTC
*** Bug 1361859 has been marked as a duplicate of this bug. ***

Comment 8 Dmitry Misharov 2016-09-09 08:42:35 UTC
Fixed and verified in 5.7.0.0.20160906172503_12f65cb. No more recursion in the policies tree.