Bug 1361340

Summary:	Review Request: python-fadvise - Python interface to posix_fadvise(2)
Product:	[Fedora] Fedora	Reporter:	Piotr Popieluch <piotr1212>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	zbyszek: fedora-review+
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-12 12:21:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Piotr Popieluch 2016-07-28 21:08:49 UTC

Spec URL: https://piotrp.fedorapeople.org/python-fadvise.spec
SRPM URL: https://piotrp.fedorapeople.org/python-fadvise-4.0.0-1.fc24.src.rpm

Description:
python-fadvise is a Python interface to posix_fadvise(2) which is used to
predeclare an access pattern for file data in order that the kernel may make
informed decisions regarding (but not limited to) scheduling I/O and caching.

It uses a private C extension module to invoke the underlying syscall. In
addition, it provides a simple client so that advice may be given via the
command-line.

Fedora Account System Username: piotrp

Comment 1 Igor Gnatenko 2016-08-08 10:56:19 UTC

> %{python2_sitearch}
don't own directory.

Comment 2 Piotr Popieluch 2016-08-08 19:57:17 UTC

(In reply to Igor Gnatenko from comment #1)
> > %{python2_sitearch}
> don't own directory.

aj.. this should be better
> %{python2_sitearch}/*

spec/srpm updated, same url.

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-08-11 02:21:39 UTC

Why don't you just build from the github tarball? That's simpler than mucking around with pypi and a separate license file [https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags].

It isn't strictly required, but it's considered good practice to specify more specific patterns in %files:
%{python2_sitearch}/%{srcname}/
%{python2_sitearch}/%{srcname}-egg.info...

I would be much much better to not install a private module in the top level python namespace: /usr/lib/python2.7/site-packages/_fadvise.so should become /usr/lib/python2.7/site-packages/fadvise/_fadvise.so. Of course this is an upstream issue, but maybe you could try to work with them to fix this.
Actually patching this is trivial:
1. move the .so file
2. change from _fadvise import ... → from ._fadvise import ...

There is no man page, and pyadvise --help isn't exactly verbose. It would be nice to extend the description in --help.

Comment 4 Piotr Popieluch 2016-08-12 22:42:24 UTC

Thanks for reviewing.

I've switched to github source.

Made %files more specific. 

The pyadvise script got dropped: https://github.com/lamby/python-fadvise/issues/1

I'm thinking on how to improve the api, I'll also move _fadvise.so. 

Updated spec and srpm for now:
Spec URL: https://piotrp.fedorapeople.org/python-fadvise.spec
SRPM URL: https://piotrp.fedorapeople.org/python-fadvise-4.0.1-1.fc24.src.rpm

Comment 5 Zbigniew Jędrzejewski-Szmek 2016-08-13 16:15:40 UTC

+ package name is OK
+ latest version
+ license is acceptable (BSD)
+ license is specified correctly
+ modern python packaging is used
+ %python_provide macro is used
+ python3 support is not needed
+ P/R/BR look OK
+ builds and install OK

Package is APPROVED.

Comment 6 Gwyn Ciesla 2016-08-15 15:04:31 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-fadvise

Comment 7 Fedora Update System 2016-09-02 18:39:19 UTC

python-fadvise-5.0.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6fcbadcf1

Comment 8 Fedora Update System 2016-09-02 18:39:49 UTC

python-fadvise-5.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-19e20103d3

Comment 9 Fedora Update System 2016-09-02 18:40:19 UTC

python-fadvise-5.0.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d018f640

Comment 10 Fedora Update System 2016-09-04 01:19:34 UTC

python-fadvise-5.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d018f640

Comment 11 Fedora Update System 2016-09-04 01:21:53 UTC

python-fadvise-5.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-19e20103d3

Comment 12 Fedora Update System 2016-09-04 01:24:13 UTC

python-fadvise-5.0.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6fcbadcf1

Comment 13 Fedora Update System 2016-09-09 21:49:47 UTC

python-fadvise-5.0.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2016-09-11 13:40:30 UTC

python-fadvise-5.0.0-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-74ea06d61c

Comment 15 Fedora Update System 2016-09-11 13:48:13 UTC

python-fadvise-5.0.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-30d3474e91

Comment 16 Fedora Update System 2016-09-12 06:50:56 UTC

python-fadvise-5.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2016-09-12 07:17:45 UTC

python-fadvise-5.0.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-74ea06d61c

Comment 18 Fedora Update System 2016-09-12 07:19:14 UTC

python-fadvise-5.0.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-30d3474e91

Comment 19 Fedora Update System 2016-09-12 12:21:46 UTC

python-fadvise-5.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2016-09-27 03:47:12 UTC

python-fadvise-5.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2016-09-27 03:50:59 UTC

python-fadvise-5.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.