Bug 1361483

Summary:	posix: leverage FALLOC_FL_ZERO_RANGE in zerofill fop
Product:	[Community] GlusterFS	Reporter:	Ravishankar N <ravishankar>
Component:	posix	Assignee:	Ravishankar N <ravishankar>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.1	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1361249	Environment:
Last Closed:	2016-08-12 09:48:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1361249
Bug Blocks:

Description Ravishankar N 2016-07-29 07:10:11 UTC

+++ This bug was initially created as a clone of Bug #1361249 +++

posix_zerofill() implements zerofilling of a given (offset,length) by
    doing a writev in a loop followed by an optional fsync on the file.

Comment 1 Vijay Bellur 2016-07-29 07:27:06 UTC

REVIEW: http://review.gluster.org/15044 (posix: leverage FALLOC_FL_ZERO_RANGE in zerofill fop) posted (#1) for review on release-3.8 by Ravishankar N (ravishankar)

Comment 2 Vijay Bellur 2016-07-30 01:18:51 UTC

REVIEW: http://review.gluster.org/15044 (posix: leverage FALLOC_FL_ZERO_RANGE in zerofill fop) posted (#2) for review on release-3.8 by Ravishankar N (ravishankar)

Comment 3 Vijay Bellur 2016-07-30 06:03:55 UTC

COMMIT: http://review.gluster.org/15044 committed in release-3.8 by Pranith Kumar Karampuri (pkarampu) 
------
commit fe1054110ac54750ca0333a727d83b14a98e165e
Author: Ravishankar N <ravishankar>
Date:   Thu Jul 28 20:42:45 2016 +0530

    posix: leverage FALLOC_FL_ZERO_RANGE in zerofill fop
    
    Backport of http://review.gluster.org/#/c/15037/
    
    posix_zerofill() implements zerofilling of a given (offset,length) by
    doing a writev in a loop followed by an optional fsync on the file.
    fallocate(2) has a FALLOC_FL_ZERO_RANGE flag which does away with all
    this and provides the same result (from a userspace application point of
    view) with a single syscall. This patch attempts the zerofill with the
    latter and falls back to the former if it fails.
    
    Tested using a libgfapi based C program on XFS and observed using gdb
    that posix_zerofill()'s call to fallocate with FALLOC_FL_ZERO_RANGE was
    a success.
    
    Change-Id: Iceaf0cbc57c52dac63540872e8538d79e8dee631
    BUG: 1361483
    Signed-off-by: Ravishankar N <ravishankar>
    Reviewed-on: http://review.gluster.org/15044
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

Comment 4 Niels de Vos 2016-08-12 09:48:11 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.2, please open a new bug report.

glusterfs-3.8.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/announce/2016-August/000058.html
[2] https://www.gluster.org/pipermail/gluster-users/