Bug 1361672

Summary:	Review Request: python-fmn-sse - allows fedora users to view their fedmsg feed in realtime
Product:	[Fedora] Fedora	Reporter:	skrzepto
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED INSUFFICIENT_DATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar, zbyszek
Target Milestone:	---	Flags:	ppisar: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-11 13:57:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449

Description skrzepto 2016-07-29 17:15:51 UTC

Spec URL: https://raw.githubusercontent.com/fedora-infra/fmn.sse/master/python-fmn-sse.spec
SRPM URL: https://github.com/fedora-infra/fmn.sse/blob/fedora_pkg_review/python-fmn-sse-0.1.0-1.fc24.src.rpm?raw=true
Description: FMN is a family of systems to manage end-user notifications triggered by fedmsg, the Fedora Federated Message bus.FMN.SSE allows fedora users to view their fedmsg feed in realtime.
Fedora Account System Username: skrzepto

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-08-01 14:48:39 UTC

The Summary is good, but the %description is a bit lacking: after reading it, I still don't know *what* this package does... I think you should spell it out in simple words.

No need to define %sum: just write the first Summary in full, and then you can refer to that text as %summary.

License tag needs a specific version for GPL. It needs to be one of the "short names" in https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses.

.egg-info doesn't need to be removed [https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/FOG5APDRQVNXR5ZOZZSVDNZVN4WURKG4/].

It doesn't work with python3? It would be nicer to package it as a Python3 application if possible.

I think that systemd-devel is probably not required. It is only used to compile C programs linked with the systemd libs.

python-fmn-sse.noarch: W: incoherent-version-in-changelog 0.1 ['0.1.0-1.fc24', '0.1.0-1']
python-fmn-sse.noarch: W: summary-ended-with-dot C FMN.SSE allows fedora users to view their fedmsg feed in realtime.

About the service file: the service most likely shouldn't run as root. Running a network-facing web server with full privileges is crazy. You should add a dedicated user (fmn-sse or similar) in %pre.

--

OK, after reading the spec and looking at the files, the biggest issues are:
- can you provide a better overview in %description what the intent of this package is, this will make further review easier.
- there needs to be some instructions how to enable the service. In particular I have no idea what the instance argument to the template should be.
- the service should run with reduced privileges.

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-02-11 13:57:19 UTC

This has gone stale. Feel free to reopen if appropriate.