Bug 1361863

Summary: Broken image for inactive Control Policy
Product: Red Hat CloudForms Management Engine Reporter: Pavel Zagalsky <pzagalsk>
Component: UI - OPSAssignee: Beni Paskin-Cherniavsky <cben>
Status: CLOSED CURRENTRELEASE QA Contact: Dmitry Misharov <dmisharo>
Severity: high Docs Contact:
Priority: high    
Version: 5.6.0CC: cben, cpelland, dmisharo, hkataria, jhardy, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: control:ui
Fixed In Version: 5.7.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1362228 (view as bug list) Environment:
Last Closed: 2017-01-11 20:14:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1362228    
Attachments:
Description Flags
BrokenImage none

Description Pavel Zagalsky 2016-07-31 10:53:16 UTC
Created attachment 1186008 [details]
BrokenImage

Description of problem:


Version-Release number of selected component (if applicable):
5.6.1.0.20160726144018_810a94f

How reproducible:
Always

Steps to Reproduce:
1. Go to Control --> Explorer --> Control Policies
2. Add a Pod/Replicator/Node or Image Control Policy
3. Check the created icon for the added Control Policy

Actual results:
The icon looks broken

Expected results:
There should be a proper icon for such action

Additional info:
Check the attached screenshot

Comment 2 Beni Paskin-Cherniavsky 2016-08-01 12:53:03 UTC
This happens for policies whose "Active" checkbox was off.
I need to add *_inactive.png icons.

Master and darga, requesting z-stream clone

Comment 5 CFME Bot 2016-08-01 20:40:52 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/60a0817c256069552f94ca907f190b066ede3724

commit 60a0817c256069552f94ca907f190b066ede3724
Author:     Beni Cherniavsky-Paskin <cben>
AuthorDate: Mon Aug 1 17:04:27 2016 +0300
Commit:     Beni Cherniavsky-Paskin <cben>
CommitDate: Mon Aug 1 17:07:47 2016 +0300

    Placeholder container policy inactive icons
    
    Missing from 18c1576372ade5d537ec377106dd52340348d656
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1361863

 .../images/100/miq_policy_containergroup_inactive.png    | Bin 0 -> 3678 bytes
 .../images/100/miq_policy_containernode_inactive.png     | Bin 0 -> 3678 bytes
 .../100/miq_policy_containerreplicator_inactive.png      | Bin 0 -> 3678 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 app/assets/images/100/miq_policy_containergroup_inactive.png
 create mode 100644 app/assets/images/100/miq_policy_containernode_inactive.png
 create mode 100644 app/assets/images/100/miq_policy_containerreplicator_inactive.png

Comment 7 CFME Bot 2016-08-02 01:45:53 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/56c75689fd8b2fa530f3581fddb2f3dc52738fb4

commit 56c75689fd8b2fa530f3581fddb2f3dc52738fb4
Author:     Beni Cherniavsky-Paskin <cben>
AuthorDate: Tue Aug 2 00:19:14 2016 +0300
Commit:     Beni Cherniavsky-Paskin <cben>
CommitDate: Tue Aug 2 00:54:10 2016 +0300

    Container policy inactive icons
    
    Missing from 18c1576372ade5d537ec377106dd52340348d656
    (and containerimage_inactive missing before that).
    
    Made by (imperfectly) copying red "X" from existing icons.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1361863

 .../images/100/miq_policy_containergroup_inactive.png | Bin 3678 -> 4697 bytes
 .../images/100/miq_policy_containerimage_inactive.png | Bin 0 -> 5350 bytes
 .../images/100/miq_policy_containernode_inactive.png  | Bin 3678 -> 3960 bytes
 .../100/miq_policy_containerreplicator_inactive.png   | Bin 3678 -> 4766 bytes
 4 files changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 app/assets/images/100/miq_policy_containerimage_inactive.png

Comment 8 Dmitry Misharov 2016-09-09 12:19:05 UTC
Fixed and verified in 5.7.0.0.20160906172503_12f65cb. Container policies have appropriate icons.