Bug 1362163
| Summary: | Improve configurability of ipfailover container(Track https://trello.com/c/228zu7Br/267-5-improve-the-configurability-of-the-ipfailover-container) | |||
|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Miheer Salunke <misalunk> | |
| Component: | RFE | Assignee: | Phil Cameron <pcameron> | |
| Status: | CLOSED NOTABUG | QA Contact: | Johnny Liu <jialiu> | |
| Severity: | urgent | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 3.1.0 | CC: | aloughla, aos-bugs, bbennett, erich, jkaur, jokerman, mcurry, mmccomas, pcameron, stwalter | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1466033 (view as bug list) | Environment: | ||
| Last Closed: | 2017-12-12 15:30:55 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1466033 | |||
|
Description
Miheer Salunke
2016-08-01 12:38:46 UTC
This can be done with a configmap root@wsfd-netdev22: ~ # oc get po | grep ipf ipf-ha-router-5-ktol1 1/1 Running 0 3h ipf-ha-router-5-t1xbd 1/1 Running 0 3h root@wsfd-netdev22: ~ # oc rsh ipf-ha-router-5-ktol1 cat /etc/keepalived/keepalived.conf > save-file Edit the save-file to add the desired checks and notifies then create a config map with the file. Edit the dc/ipf-..... to include the config map setup and an ENV, KEEPALIVED_OPTIONS="-f ppp" pointing to config map mount point. The config map provides a complete replacement for the keepalived.conf file so you can do anything that keepalived supports. I will verify that this will work. bbennett This corresponds to the Trello card I am working on, so I took the bug. Spoke to Ben about this. The comment 2 approach is not flexible enough. The keepalived.conf file is created every time the pod is started and items can change in the file. A statically captured file passed in the config map won't have the changes. Instead we will have a env var for the path names to the check and notify scripts. One way to supply the check and notify scripts is through configmaps. Code changes: https://github.com/openshift/origin/pull/11644 Documentation changes: https://github.com/openshift/openshift-docs/pull/3355 Commit pushed to master at https://github.com/openshift/openshift-docs https://github.com/openshift/openshift-docs/commit/9ee13b59401fe86c867fa6a498673785a210f254 Ipfailover check and notify script support Openshift 3.5 feature. Add options to 'oadm ipfailover' to configure the check script and notify scripts and also control the period the check script runs. Keepalived periodically checks whether the application is running properly. In the default case the test is a simple verification that something is listening on the watch port. This PR permits the user to supply an additional check script that is run in the ipfailover container context to verify that the application is operating properly. For example, a web server can be tested by accessing the watch port and verifying the response. Whenever a node changes state to MASTER, BACKUP, or FAULT a notify script can be called. This script has 3 parameters filled in by keepalived: $1 - "GROUP"|"INSTANCE" $2 - name of group or instance $3 - target state of transition ("MASTER"|"BACKUP"|"FAULT") --check-script="check_script" The check script is a script in the keepalived container that verifies the service is running properly. The script must return 0 for OK and 1 for FAIL. These checks are in addition to verifying that the watch port is listening. --notify-script="notify_script" The notify script is a script in the keepalived container that is called whenever the keepalived state transitions to (MASTER|BACKUP|FAULT) --check-interval= The check script is run every seconds. Default is 2. Note: the scripts name is the full path to the script. Fixes bug 1362163 https://trello.com/c/228zu7Br/267-5-improve-the-configurability-of-the-ipfailover-container-operations Signed-off-by: Phil Cameron <pcameron> *** Bug 1363697 has been marked as a duplicate of this bug. *** Cloned this bug to add the preemption strategy support see 1466033 |