Bug 1362224

Summary:	Bash completion does not work for ninja-build because it was renamed from upstream name "ninja"
Product:	[Fedora] Fedora	Reporter:	Andrew Stitcher <astitcher>
Component:	ninja-build	Assignee:	Ben Boeckel <fedora>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	24	CC:	fedora, i
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ninja-build-1.7.1-1.fc24 ninja-build-1.7.1-1.fc23	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-11 21:55:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andrew Stitcher 2016-08-01 15:39:04 UTC

Description of problem:

The upstream name for the ninja build system build command is "ninja". In Fedora this has been renamed to "ninja-build" because of a naming clash with another package.

However the back completion script has not been altered in the Fedora package to account for the new name and so does not complete correctly. Instead of completing ninja targets in the appropriate place it just completes using the fallback _minimal completer and only selects present files.

This is annoying.

I am indifferent to the name of the executable (Bug 1166135), but I can see no reason why the completion shouldn't work whatever the command name. It should be straightforward to parameterise the completion script and have a slightly different version in the Fedora package.

Workaround:

You can work around the problem by making "ninja" a shell alias to "ninja-build". However this is not a very robust solution, and it requires always using "ninja" to call the executable even though by now ninja-build is what I'm used to!

Comment 1 Andrew Stitcher 2016-08-01 17:40:46 UTC

This applies to the package

ninja-build-1.6.0-3.fc24

I can see the issue is fixed in 1.7.1, perhaps that could be released on f24.

Comment 2 Fedora Update System 2016-08-03 03:45:23 UTC

ninja-build-1.7.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5285c8e28e

Comment 3 Fedora Update System 2016-08-03 03:45:28 UTC

ninja-build-1.7.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-19599cc569

Comment 4 Fedora Update System 2016-08-04 01:54:59 UTC

ninja-build-1.7.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5285c8e28e

Comment 5 Fedora Update System 2016-08-04 01:58:01 UTC

ninja-build-1.7.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-19599cc569

Comment 6 Fedora Update System 2016-08-11 21:55:02 UTC

ninja-build-1.7.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2016-08-12 01:23:13 UTC

ninja-build-1.7.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.