Bug 1364194

Summary:	Review Request: pintail - Build web sites from Mallard sources
Product:	[Fedora] Fedora	Reporter:	William Moreno <williamjmorenor>
Component:	Package Review	Assignee:	Eduardo Mayorga <e>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dhanvicse, e, me, package-review
Target Milestone:	---	Flags:	e: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-11 15:42:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1346060

Description William Moreno 2016-08-04 16:41:46 UTC

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/pintail.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/pintail-0.3-1gitd669691.fc26.src.rpm
Description: Build web sites from Mallard sources
Fedora Account System Username: williamjmorenor

Test builds: https://copr.fedorainfracloud.org/coprs/williamjmorenor/fedora-review-test/build/438222/

Incorrect fsf adress reported upstream: https://github.com/projectmallard/pintail/issues/21

Comment 1 William Moreno 2016-08-04 16:51:11 UTC

*** Bug 1334112 has been marked as a duplicate of this bug. ***

Comment 2 Eduardo Mayorga 2016-08-05 17:10:47 UTC

python3-elasticsearch requires python3-urllib3, so please drop it.

Comment 3 William Moreno 2016-08-05 20:09:18 UTC

This is not a blocker issue.

Comment 4 Eduardo Mayorga 2016-08-06 04:16:27 UTC

You are not correct here. Packages must not contain unnecessary explicit Requires on libraries. See: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Explicit_Requires.

Comment 5 Eduardo Mayorga 2016-08-08 04:54:04 UTC

[mayorga@topo results]$ rpmlint -i pintail-0.3-1gitd669691.fc25.noarch.rpm 
pintail.noarch: E: explicit-lib-dependency python3-urllib3
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

Please remove this dependency to continue with the review.

Comment 6 William Moreno 2016-08-10 03:56:22 UTC

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/pintail.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/pintail-0.3-1git6f2daf7.fc26.src.rpm

Comment 7 William Moreno 2016-08-15 21:53:36 UTC

Reviewer ping :)

Comment 8 Eduardo Mayorga 2016-08-22 05:23:32 UTC

Release tag should look like 1.YYYYMMDDgit%{shortcommit0}%{?dist}. See the note on post-release packages: https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Snapshot_packages.

Otherwise, this package looks fine.

Comment 9 William Moreno 2016-08-22 20:37:25 UTC

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/pintail.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/pintail-0.3-1.20160805git6f2daf7.fc26.src.rpm

Comment 10 Eduardo Mayorga 2016-08-24 19:52:13 UTC

PACKAGE APPROVED

Comment 11 Gwyn Ciesla 2016-08-25 12:58:59 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pintail

Comment 12 Fedora Update System 2016-09-30 20:24:17 UTC

pintail-0.3-1.20160805git6f2daf7.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f9c789f707

Comment 13 Fedora Update System 2016-10-01 05:26:43 UTC

pintail-0.3-1.20160805git6f2daf7.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9460866789

Comment 14 Fedora Update System 2016-10-01 05:27:50 UTC

pintail-0.3-1.20160805git6f2daf7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-249e1f83f6

Comment 15 Fedora Update System 2016-10-11 15:42:53 UTC

pintail-0.3-1.20160805git6f2daf7.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2016-10-11 19:55:33 UTC

pintail-0.3-1.20160805git6f2daf7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2016-10-11 23:21:57 UTC

pintail-0.3-1.20160805git6f2daf7.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.