Bug 1364309

Summary: Should not show warnings about no CPU request when create hpa on dc with cpu limits set
Product: OpenShift Container Platform Reporter: Yanping Zhang <yanpzhan>
Component: Management ConsoleAssignee: Samuel Padgett <spadgett>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.3.0CC: aos-bugs, jforrest, jokerman, mmccomas, tdawson
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-19 12:55:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
create-hpa
none
after-create-hpa none

Description Yanping Zhang 2016-08-05 03:02:41 UTC 
Description of problem:
After create app with cpu limits set on web console, on dc page click "Add autoscaler" to create hpa, it always show warning info "This deployment config does not have any containers with a CPU request set. Autoscaling will not work without a CPU request." In fact, containers will have cpu requests set as cpu limits automatically, and autoscaling can work.

Version-Release number of selected component (if applicable):
OpenShift v3.3.0.14
Kubernetes v1.3.0+57fb9ac


How reproducible:
Always

Steps to Reproduce:
Metrics is deployed in advance.
1.Create app from image with cpu limits set on web console.
2.Click "Add autoscaler" to create hpa on dc page.
3.Check dc page after hpa was created.

Actual results:
1.App is created successfully
2.Show warning info on hpa creation page:"This deployment config does not have any containers with a CPU request set. Autoscaling will not work without a CPU request." , and could create hpa successfully.
3.There is also warning info: "This deployment config does not have any containers with a CPU request set. Autoscaling will not work without a CPU request. Set resource requests and limits"

Expected results:
2,3, Should no warning info.

Additional info:
Comment 1 Yanping Zhang 2016-08-05 03:06:27 UTC 
Created attachment 1187733 [details]
create-hpa
Comment 2 Yanping Zhang 2016-08-05 03:06:57 UTC 
Created attachment 1187734 [details]
after-create-hpa
Comment 3 Samuel Padgett 2016-08-05 16:17:43 UTC 
https://github.com/openshift/origin-web-console/pull/301
Comment 4 Jessica Forrester 2016-08-05 20:39:03 UTC 
merging to origin in https://github.com/openshift/origin/pull/10253
Comment 5 Jessica Forrester 2016-08-05 20:41:11 UTC 
sorry forgot this was an OCP bug, leaving as assigned to origin PR merges
Comment 6 Yanping Zhang 2016-08-12 03:20:02 UTC 
Tested on openshift v3.3.0.18. After create app with cpu limits set on web console, when create hpa or after created hpa, will not show warning info about no cpu request now.
The bug has been fixed, so move it to Verified.