Bug 1364646

Summary: Review Request: nodejs-svgo - Nodejs-based tool for optimizing SVG vector graphics files
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: eclipseo, package-review, vanmeeuwen+fedora
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-22 12:53:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1364645, 1493764, 1493765    
Bug Blocks: 956806, 1364647, 1387531    

Description Jared Smith 2016-08-06 08:11:12 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-svgo/nodejs-svgo.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-svgo/nodejs-svgo-0.6.6-4.fc26.src.rpm
Description: Nodejs-based tool for optimizing SVG vector graphics files
Fedora Account System Username: jsmith
Comment 1 Robert-André Mauchin 🐧 2017-09-20 13:58:18 UTC 
Please update to version 0.7.2.


BuildRequires:	npm(whet.extend) is not needed anymore.


nodejs-csso is not yet packaged and is required. Please do a request for it.
Comment 2 Jared Smith 2017-09-21 00:35:51 UTC 
npm(whet.extend) still seems to be needed.  I've submitted it and npm(csso) for review.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-svgo/nodejs-svgo.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-svgo/nodejs-svgo-0.7.2-1.fc28.src.rpm
Comment 3 Robert-André Mauchin 🐧 2017-09-21 09:28:57 UTC 
 - Error: Cannot find module 'js-yaml'

⇒ Move js-yaml BR outside of enable_tests


Package otherwise accepted.
Comment 4 Jared Smith 2017-09-21 22:59:01 UTC 
'Requested package in ticket https://pagure.io/releng/fedora-scm-requests/issue/1502'
Comment 5 Gwyn Ciesla 2017-09-21 23:13:47 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-svgo
Comment 6 Jared Smith 2017-09-22 12:53:32 UTC 
In rawhide, closing bug