Bug 1365320

Summary:	Review Request: simplenote - Simplenote.com desktop client
Product:	[Fedora] Fedora	Reporter:	Robert Bost <rbost>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, rbost
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-22 18:40:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Robert Bost 2016-08-08 23:22:29 UTC

Spec URL: https://bostrt.fedorapeople.org/simplenote.spec
SRPM URL: https://bostrt.fedorapeople.org/simplenote-1.0.2-1.fc24.src.rpm
Description:

I've created a package for the simplenote.com Linux desktop client. I look forward to a review and any improvement suggestions. 

simplenote is a note-taking app with storage hosted by Automattic.

Fedora Account System Username: bostrt

Comment 1 Igor Gnatenko 2016-08-09 06:41:39 UTC

cp -r $RPM_BUILD_DIR/simplenote-electron-%{version}/release/Simplenote-linux-x64/* $RPM_BUILD_ROOT%{_datadir}/simplenote/

doesn't seem like true open source.

Comment 2 Robert Bost 2016-08-09 22:47:12 UTC

(In reply to Igor Gnatenko from comment #1)
> 
> doesn't seem like true open source.

I'm not sure if I follow what you mean by true open source. Can you clarify your concerns and I can check on it? Also, if you can help me understand how that line would lead you to believe its not true open source, I'm happy to adjust it so its a little clearer.

Turns out, I'm going to need to make some adjustments to the .spec anyways. Part of the build process requires reaching out to the network to pull down npm dependencies. This is going to need to be removed since koji does not allow for network connections created outside of the standard rpmbuild macros during build.

Also, I neglected to state this in my initial update, but this is my first package submission. I'm in search of a sponsor as well and will be reaching out to the devel list soon.


I'll be following up with a revision of my SRPM and .spec.

Comment 3 Robert Bost 2016-08-22 18:40:19 UTC

Due to the amount of dependencies that would be required by Simplenote this is not going to be accomplished in foreseeable future. I'm focusing on some other packages on my list.