Bug 1365415

Summary: Can't push code to gitserver repo so no build will be triggered.
Product: OpenShift Container Platform Reporter: XiuJuan Wang <xiuwang>
Component: ImageStreamsAssignee: Cesar Wong <cewong>
Status: CLOSED ERRATA QA Contact: Wang Haoran <haowang>
Severity: low Docs Contact:
Priority: medium    
Version: 3.3.0CC: aos-bugs, cewong, haowang, jokerman, mmccomas, pweil, tdawson
Target Milestone: ---Keywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Change to using the --depth argument when calling git clone from 'oc new-app' causes origin git server to hang. Consequence: Pushing source code to the origin git server results in a hang. Fix: Update the git server code to allow --depth argument without hanging. Result: Pushing source code to the origin git server no longer results in a hang and new-app is called successfully by the git server.
 Story Points: ---
Clone Of: 1334147 Environment:
Last Closed: 2017-01-18 12:52:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1334147    
Bug Blocks:    

Description XiuJuan Wang 2016-08-09 08:23:12 UTC 
Could reproduce this bug with origin-gitserver(317a4a0a087e) with ocp 3.3.0.17 env now.

+++ This bug was initially created as a clone of Bug #1334147 +++

Description of problem:
When push code to gitserver repo via app route, show below error. No build is triggered.
# git push openshift master
Password for 'http://xiuwang@git-xiuwang.0506-5sa.qe.rhcloud.com':
Counting objects: 267, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (166/166), done.
Writing objects: 100% (267/267), 41.00 KiB, done.
Total 267 (delta 88), reused 267 (delta 88)
error: RPC failed; result=22, HTTP code = 504
fatal: The remote end hung up unexpectedly
fatal: recursion detected in die handler
Everything up-to-date

#When push code to gitserver via app service ip or port-forward 8080 in localhost, will hang on long long time.

Version-Release number of selected component (if applicable):
openshift/origin-gitserver(6ae0b13def4c)

How reproducible:
always

Steps to Reproduce:
1.Create the Git Server
$ oc create -f gitserver.yaml
2.Grant edit access to the git service account
$ oc policy add-role-to-user edit -z git
3.Push a repository to your git server
# clone a public repository
$ git clone https://github.com/openshift/ruby-hello-world.git
# add a remote for your git server
$ cd ruby-hello-world
$ git remote add openshift http://git-myproject.infra.openshift.com/ruby-hello-world.git  
# push the code to the git server
$ git push openshift master

Actual results:

$ git push openshift master
Password for 'http://xiuwang@git-xiuwang.0506-5sa.qe.rhcloud.com':
Counting objects: 267, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (166/166), done.
Writing objects: 100% (267/267), 41.00 KiB, done.
Total 267 (delta 88), reused 267 (delta 88)
error: RPC failed; result=22, HTTP code = 504
fatal: The remote end hung up unexpectedly
fatal: recursion detected in die handler
Everything up-to-date

Expected results:
Could push code to gitserver repo, and trigger new build.

Additional info:
Should works as https://bugzilla.redhat.com/show_bug.cgi?id=1252826#c3

--- Additional comment from Cesar Wong on 2016-05-12 18:32:52 EDT ---

new-app changed to use --depth=1 when cloning repositories from git servers. That parameter seems to make the gitserver server hang. Investigating.

--- Additional comment from Cesar Wong on 2016-05-19 19:15:05 EDT ---

PR https://github.com/openshift/origin/pull/8953
Comment 1 Cesar Wong 2016-08-12 21:34:18 UTC 
PR https://github.com/openshift/origin/pull/10396
Comment 2 Cesar Wong 2016-08-14 15:50:45 UTC 
Fix merged. Testing it will require an updated openshift/origin-gitserver image.
Comment 3 XiuJuan Wang 2016-08-16 02:29:11 UTC 
Fixed in ocp (openshift v3.3.0.19)
with openshift/origin-gitserver (imageid 098f6fe68631).
Could trigger new builds when push code to git server.
Comment 4 Wang Haoran 2016-08-19 05:54:27 UTC 
Reopen this bug , as the image is rebuilt, and the problems comes again.
docker.io/openshift/origin-gitserver     0868b05342d1
Comment 7 Cesar Wong 2016-09-30 03:50:38 UTC 
Wang Haoran, can you still reproduce this? I am not able to reproduce locally.
Comment 8 Wang Haoran 2016-09-30 07:08:55 UTC 
It works now with image: openshift/origin-gitserver  96cc3498dad5
Comment 10 errata-xmlrpc 2017-01-18 12:52:20 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0066