Bug 1365607

Summary: configuration file syntax error: Duplicate security driver none although it's defined only once
Product: [Community] Virtualization Tools Reporter: jean-christophe manciot <actionmystique>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED UPSTREAM QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: crobinso, libvirt-maint, rbalakri
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-10 14:45:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description jean-christophe manciot 2016-08-09 16:41:59 UTC
Description of problem:
----------------------
sudo systemctl status libvirt-bin
● libvirt-bin.service - Virtualization daemon
   Loaded: loaded (/lib/systemd/system/libvirt-bin.service; enabled; vendor preset: enabled)
   Active: inactive (dead) since Tue 2016-08-09 18:30:13 CEST; 2s ago
     Docs: man:libvirtd(8)
           http://libvirt.org
  Process: 10025 ExecStart=/usr/sbin/libvirtd $libvirtd_opts (code=exited, status=0/SUCCESS)
 Main PID: 10025 (code=exited, status=0/SUCCESS)
    Tasks: 16
   Memory: 5.7M
      CPU: 2.838s
   CGroup: /system.slice/libvirt-bin.service
           ├─7422 /usr/sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/virl-data-flat.conf --leasefile-ro --dhcp-script=/usr/libexec/libvirt_leaseshelper
...

Aug 09 18:30:12 samsung-ubuntu dnsmasq[9230]: read /etc/hosts - 12 addresses
Aug 09 18:30:12 samsung-ubuntu dnsmasq[9509]: read /var/lib/libvirt/dnsmasq/virl-data-flat1.addnhosts - 0 addresses
Aug 09 18:30:12 samsung-ubuntu dnsmasq[9230]: read /var/lib/libvirt/dnsmasq/virtual-bridge-3.addnhosts - 0 addresses
Aug 09 18:30:12 samsung-ubuntu dnsmasq-dhcp[9230]: read /var/lib/libvirt/dnsmasq/virtual-bridge-3.hostsfile
Aug 09 18:30:12 samsung-ubuntu libvirtd[10025]: libvirt version: 2.1.0
Aug 09 18:30:12 samsung-ubuntu libvirtd[10025]: hostname: samsung-ubuntu.actionmystique.net
Aug 09 18:30:12 samsung-ubuntu libvirtd[10025]: ignoring dangling symlink '/media/actionmystique/SAMSUNG-850-Ext4/Images/Cisco/NFV/CSR-1000v/CSR1000v-16.2.2-bootstrap-config
Aug 09 18:30:13 samsung-ubuntu libvirtd[10025]: configuration file syntax error: Duplicate security driver none
Aug 09 18:30:13 samsung-ubuntu libvirtd[10025]: Initialization of QEMU state driver failed: configuration file syntax error: Duplicate security driver none
Aug 09 18:30:13 samsung-ubuntu libvirtd[10025]: Driver state initialization failed

Despite only one setting in /etc/libvirt/qemu.conf:
...
#security_driver = "selinux"
security_driver = "none"

No other feature is configured.
If I remove security_driver = "none", the default security driver is "apparmor".

Version-Release number of selected component (if applicable):
------------------------------------------------------------
git sources 2.1.0
Ubuntu 16.04

How reproductible:
-----------------
Build from sources with the following options:
        export CLEAN_SUBMODULE=1
        ./autogen.sh
        ./configure     --with-openssl \
                        --with-systemd-daemon \
                        --with-numactl \
                        --with-numad \
                        --with-default-editor=gedit \
                        --without-xen --without-xen-inotify --without-xenapi --without-libxl \
                        --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=/usr/lib

Comment 1 jean-christophe manciot 2016-08-09 17:07:04 UTC
No such issue with 2.0.0 with the same /etc/libvirt/qemu.conf ("none" defined).

Comment 2 Cole Robinson 2016-08-10 14:38:37 UTC
Thanks for the report, indeed it's a regression in v2.1.0. I sent a patch:

http://www.redhat.com/archives/libvir-list/2016-August/msg00557.html

Comment 3 Cole Robinson 2016-08-10 14:45:10 UTC
Upstream now:

commit 856965b36246b26002af409262846317477ea631
Author: Cole Robinson <crobinso>
Date:   Wed Aug 10 10:32:03 2016 -0400

    qemu: fix qemu.conf security_driver