Bug 1365734

Summary:	Mem leak in meta_default_readv in meta xlators
Product:	[Community] GlusterFS	Reporter:	Mohammed Rafi KC <rkavunga>
Component:	unclassified	Assignee:	Mohammed Rafi KC <rkavunga>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.2	CC:	bugs, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1364522	Environment:
Last Closed:	2016-08-24 10:20:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1362397, 1364522
Bug Blocks:

Description Mohammed Rafi KC 2016-08-10 06:06:39 UTC

+++ This bug was initially created as a clone of Bug #1364522 +++

+++ This bug was initially created as a clone of Bug #1362397 +++

Description of problem:

Meta xlators leaking iobuf and iobref in read code path, from the function meta_default_readv


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. create a volume and do a fuse mount
2. read the file /mnt/.meta/version in loop
3.

Actual results:

memleak

Expected results:

there should not be any memleak

Additional info:

--- Additional comment from Mohammed Rafi KC on 2016-08-02 08:50:25 CEST ---

I opened the bug in glusterd, because I couldn't find a component named meta.

--- Additional comment from Vijay Bellur on 2016-08-02 08:53:42 CEST ---

REVIEW: http://review.gluster.org/15068 (meta: fix memory leak in meta xlators) posted (#1) for review on master by mohammed rafi  kc (rkavunga)

--- Additional comment from Vijay Bellur on 2016-08-05 12:57:00 CEST ---

COMMIT: http://review.gluster.org/15068 committed in master by Raghavendra G (rgowdapp) 
------
commit d297d2bdfc4d5ba99c37b22dd1ae0f8e8e92fe7b
Author: Mohammed Rafi KC <rkavunga>
Date:   Tue Aug 2 11:59:42 2016 +0530

    meta: fix memory leak in meta xlators
    
    meta xlator is leaking iobuf and iobrefs in read path
    
    This patch fixes memleak in meta_default_read code path
    
    Change-Id: Ieb413267604d9870dbe6e11258fffd279a7bd7cf
    BUG: 1362397
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/15068
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>

--- Additional comment from Vijay Bellur on 2016-08-05 16:06:58 CEST ---

REVIEW: http://review.gluster.org/15102 (meta: fix memory leak in meta xlators) posted (#1) for review on release-3.7 by Oleksandr Natalenko (oleksandr)

Comment 1 Vijay Bellur 2016-08-10 06:12:32 UTC

REVIEW: http://review.gluster.org/15123 (meta: fix memory leak in meta xlators) posted (#1) for review on release-3.8 by mohammed rafi  kc (rkavunga)

Comment 2 Vijay Bellur 2016-08-13 08:07:56 UTC

COMMIT: http://review.gluster.org/15123 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit ba7a337ab250761492b153c1caee0c21b28e08a1
Author: Mohammed Rafi KC <rkavunga>
Date:   Tue Aug 2 11:59:42 2016 +0530

    meta: fix memory leak in meta xlators
    
    meta xlator is leaking iobuf and iobrefs in read path
    
    This patch fixes memleak in meta_default_read code path
    
    Backport of>
    >Change-Id: Ieb413267604d9870dbe6e11258fffd279a7bd7cf
    >BUG: 1362397
    >Signed-off-by: Mohammed Rafi KC <rkavunga>
    >Reviewed-on: http://review.gluster.org/15068
    >Smoke: Gluster Build System <jenkins.org>
    >Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    >CentOS-regression: Gluster Build System <jenkins.org>
    >NetBSD-regression: NetBSD Build System <jenkins.org>
    >Reviewed-by: Poornima G <pgurusid>
    
    (cherry picked from commit d297d2bdfc4d5ba99c37b22dd1ae0f8e8e92fe7b)
    
    
    Change-Id: I1141d3770f2d0f24ac5954d12a6bb3cc4a900f44
    BUG: 1365734
    Signed-off-by: Mohammed Rafi KC <rkavunga>
    Reviewed-on: http://review.gluster.org/15123
    Smoke: Gluster Build System <jenkins.org>
    Tested-by: Oleksandr Natalenko <oleksandr>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-by: Prashanth Pai <ppai>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-08-24 10:20:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.3, please open a new bug report.

glusterfs-3.8.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/announce/2016-August/000059.html
[2] https://www.gluster.org/pipermail/gluster-users/