Bug 1365745
| Summary: | Review Request: fwknop-gui - GUI client for Fwknop | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jakub Jelen <jjelen> |
| Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | ignatenko:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-19 19:53:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jakub Jelen
2016-08-10 07:04:44 UTC
> Summary: A cross platform gui client for Fwknop remove "A" from the beginning. Actually I would prefer to have just "GUI client for Fwknop". > Group: Applications/Internet not needed and not used. > Source: https://incomsystems.biz/fwknop-gui/downloads/fwknop-gui-%{version}.tar.gz Source: %{url}/downloads/%{name}-%{version}.tar.gz > BuildRequires: qrencode-devel BuildRequires: pkgconfig(libqrencode) > Requires: fwknop > Requires: wxGTK3 > Requires: gpgme > Requires: qrencode not needed, linked dynamically from binary > %setup -q -n fwknop-gui %autosetup -n %{name} > make %{?_smp_mflags} %make_build > make install DESTDIR=%{buildroot} %make_install > install -D fwknop-gui.appdata.xml %{buildroot}/%{_datadir}/appdata/fwknop-gui.appdata.xml 1. add "-p" and "-m0644" to install 2. drop "/" after %{buildroot} 3. replace "fwknop-gui" with "%{name}" > desktop-file-validate %{buildroot}%{_datadir}/applications/fwknop-gui.desktop > appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/*.appdata.xml 1. drop "/" after %{buildroot} 2. replace "fwknop-gui" with "%{name}" 3. Move to separate %check section > %doc %{_mandir}/man8/* %doc %{_mandir}/man8/%{name}.8* > %attr(0755,root,root) %{_bindir}/fwknop-gui > %attr(0644,root,root) %{_datadir}/applications/fwknop-gui.desktop > %attr(0644,root,root) %{_datadir}/pixmaps/fwknop-gui.png > %attr(0644,root,root) %{_datadir}/appdata/fwknop-gui.appdata.xml 1. no need to specify attrs manually 2. replace "fwknop-gui" with "%{name}" * Missing BuildRequires: gcc-c++ * Missing BuildRequires: make * Consider building out-of-tree build: %prep ... mkdir %{_target_platform} %build pushd %{_target_platform} %cmake .. popd %make_build -C %{_target_platform} %install %make_install -C %{_target_platform} Thank you for the comments. I addressed your mentioned details. I didn't modify the spec file to build out-of-tree, because it fails for the manual pages (will report upstream and try to move it out-of-tree in the future). Spec URL: https://jjelen.fedorapeople.org/fwknop-gui.spec SRPM URL: https://jjelen.fedorapeople.org/fwknop-gui-1.3-2.src.rpm you missed to address: > desktop-file-validate %{buildroot}%{_datadir}/applications/fwknop-gui.desktop > appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/appdata/*.appdata.xml 1. drop "/" after %{buildroot} 2. replace "fwknop-gui" with "%{name}" 3. Move to separate %check section Also I completely forgot: > Release: 2 it must be 2%{?dist} Others looks good. Thank you for reminder. I also completely missed the dist. Current SRPM and specs, just for the completeness: Spec URL: https://jjelen.fedorapeople.org/fwknop-gui.spec SRPM URL: https://jjelen.fedorapeople.org/fwknop-gui-1.3-2.fc26.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/fwknop-gui fwknop-gui-1.3-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e554dd98df fwknop-gui-1.3-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-85b83e5cb8 fwknop-gui-1.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a9d855e173 fwknop-gui-1.3-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e554dd98df fwknop-gui-1.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a9d855e173 fwknop-gui-1.3-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-85b83e5cb8 fwknop-gui-1.3-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. fwknop-gui-1.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. fwknop-gui-1.3-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |