Bug 1365751
| Summary: | force_fail plugin fails with python3 | ||
|---|---|---|---|
| Product: | [oVirt] otopi | Reporter: | Yedidyah Bar David <didi> |
| Component: | Plugins.General | Assignee: | Yedidyah Bar David <didi> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yedidyah Bar David <didi> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | master | CC: | bugs, didi, oourfali, pstehlik, sbonazzo, ylavi |
| Target Milestone: | ovirt-4.1.0-alpha | Keywords: | CodeChange |
| Target Release: | 1.6.0 | Flags: | rule-engine:
ovirt-4.1+
ylavi: Triaged+ ylavi: planning_ack+ sbonazzo: devel_ack+ pstehlik: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-01-17 12:42:09 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1316950, 1379402 | ||
Is this a codechange? (In reply to Yaniv Dary from comment #1) > Is this a codechange? Currently it is, until patch for bug 1316950 is merged. Nothing for QE - CodeChange Didi, referenced patch has been merged, anything else preventing to move to modified? The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified. Closed based on comment #2 |
Description of problem: force_fail sets _prio to the env var 'OTOPI_FORCE_FAIL_PRIORITY', and if that's not set, to None. Later on, otopi compares priorities, and python3 fails when comparing None to a number, e.g.: Traceback (most recent call last): File "/usr/lib/python3.5/site-packages/otopi/__main__.py", line 88, in main installer.execute() File "/usr/lib/python3.5/site-packages/otopi/main.py", line 151, in execute self.context.buildSequence() File "/usr/lib/python3.5/site-packages/otopi/context.py", line 665, in buildSequence self._sequence = self._toposortBuildSequence() File "/usr/lib/python3.5/site-packages/otopi/context.py", line 554, in _toposortBuildSequence j for j, m in enumerate(methods) File "/usr/lib/python3.5/site-packages/otopi/context.py", line 558, in <listcomp> m['priority'] < method['priority'] TypeError: unorderable types: NoneType() < int()