Bug 1366195

Summary:	[Bitrot - RFE]: On demand scrubbing option to scrub
Product:	[Community] GlusterFS	Reporter:	Kotresh HR <khiremat>
Component:	bitrot	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:	bugs <bugs>
Priority:	unspecified
Version:	mainline	CC:	amukherj, bugs, rcyriac, rhinduja, rhs-bugs, storage-qa-internal
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	v3.10.0	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:	1359588	Environment:
Last Closed:	2017-03-08 09:32:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1359588
Bug Blocks:

Description Kotresh HR 2016-08-11 09:38:03 UTC

+++ This bug was initially created as a clone of Bug #1359588 +++

Description of problem:

Currently scrub-frequency value for scrubber is {hourly|daily|weekly|biweekly}. So scrubber need to wait for that frequency value before starting scrubbing. This patch implements on demand scrubbing. If user set scrub value ondemand then scrubber do not need to wait for scrubbing frequency, Scrubber will start crawling of filesystem immediately. Command for on-demand scrubbing will be. 

#gluster volume bitrot <VOLNAME> scrub ondemand

Comment 1 Vijay Bellur 2016-08-11 09:39:17 UTC

REVIEW: http://review.gluster.org/15111 (feature/bitrot: Ondemand scrub option for bitrot) posted (#3) for review on master by Kotresh HR (khiremat)

Comment 2 Vijay Bellur 2016-08-12 07:45:18 UTC

REVIEW: http://review.gluster.org/15111 (feature/bitrot: Ondemand scrub option for bitrot) posted (#4) for review on master by Kotresh HR (khiremat)

Comment 3 Worker Ant 2016-08-24 17:59:12 UTC

REVIEW: http://review.gluster.org/15111 (feature/bitrot: Ondemand scrub option for bitrot) posted (#5) for review on master by Kotresh HR (khiremat)

Comment 4 Worker Ant 2016-08-25 21:39:48 UTC

COMMIT: http://review.gluster.org/15111 committed in master by Vijay Bellur (vbellur) 
------
commit 0b3e4130b576c11156d6327e4cc3c9310a74c143
Author: Kotresh HR <khiremat>
Date:   Fri Aug 5 09:03:22 2016 +0530

    feature/bitrot: Ondemand scrub option for bitrot
    
    The bitrot scrubber takes 'hourly/daily/biweekly/monthly'
    as the values for 'scrub-frequency'. There is no way
    to schedule the scrubbing when the admin wants it.
    
    Ondemand scrubbing brings in the new option 'ondemand'
    with which the admin can start scrubbing ondemand.
    It starts the scrubbing immediately.
    
    Ondemand scrubbing is successful only if the scrubber
    is in 'Active (Idle)' (waiting for it's next frequency
    cycle to start scrubbing). It is not entertained when
    the scrubber is in 'Paused' or already running.
    
    Here is the command line syntax.
    
    gluster volume bitrot <vol name> scrub ondemand
    
    Change-Id: I84c28904367eed827a7dae8d6a535c14b28e9f4d
    BUG: 1366195
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/15111
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Venky Shankar <vshankar>