Bug 1366905
| Summary: | [RFE] Allow multiple IP's / text fields for network filters, specifically clean-traffic | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | jax2568 | ||||||||
| Component: | RFEs | Assignee: | Dominik Holler <dholler> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Michael Burman <mburman> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | future | CC: | apinnick, bugs, danken, dholler, jax2568, mburman, troels, ylavi | ||||||||
| Target Milestone: | ovirt-4.2.0 | Keywords: | FutureFeature | ||||||||
| Target Release: | 4.2.0 | Flags: | danken:
ovirt-4.2?
gklein: testing_plan_complete- rule-engine: planning_ack? danken: devel_ack+ mburman: testing_ack+ |
||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | ovirt-engine-4.2.0-0.0.master.20170901193740.git7900511.el7.centos.noarch.rpm | Doc Type: | Enhancement | ||||||||
| Doc Text: |
The engine already supports filtering the network communication of VMs. Now it is possible to configure the filter parameters using the REST-API.
See http://www.ovirt.org/develop/release-management/features/network/networkfilterparameters/#current-implementation-status for details.
|
Story Points: | --- | ||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2017-12-20 11:23:06 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1502496 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
jax2568
2016-08-14 15:46:15 UTC
Hello - is there anything else needed for this? Or is it a possibility? Not sure how this Bugzilla/feature request should work or if it's in the right place or not. (In reply to jax2568 from comment #1) > Hello - is there anything else needed for this? Or is it a possibility? Not > sure how this Bugzilla/feature request should work or if it's in the right > place or not. We are currently reviewing this for oVirt 4.1. No other needs from you at this point. The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified. This RFE is not in 4.1.0-0.2.master.20161210231201.git26a385e.el7.centos Hello, I see this was updated with the line below: Flags: ovirt-4.1? → ovirt-4.2? Is this not included anymore in 4.1? If not, how long until 4.2? ovirt-4.2 schedule has not been decided yet. But we do know that we've missed 4.1's feature freeze. Maybe we can help you write a vdsm hook to enable the functionality on the mean while? Ok, thanks for the update.
>>Maybe we can help you write a vdsm hook to enable the functionality on the mean while?
Sure however, I don't have any experience with writing hooks for vdsm.
Basically, the clean traffic filter works as expected but it the VM has multiple IP's, only one of them would work.
What would be involved with a vdsm hook to accomplish what we need to do?
Created attachment 1232201 [details]
untested /usr/libexec/vdsm/hooks/before_vm_start/multiips hook
place this in the hook directory, and define a vm custom property named multiips. Set this property to a comma-separated list of ip addresses. The hook script would allow the VM to use these ips on all of its clean-traffic filters.
Hi,
Thanks for that hook - I will get this tested!
>place this in the hook directory, and define a vm custom property named multiips.
Sorry, I'm not exactly sure how I would create a custom property. Is there an article or guide on how to do this?
@Dan Kenigsberg,
Thanks for that link. I took a look at that earlier actually, but wasn't 100% sure what I was supposed to put for the values. Would it be like this?
engine-config -s CustomDeviceProperties="{multiips}" --cver=3.3
This discussion about the hack does not really belong to this RFE. Let's continue it on users. A good start would be engine-config -s UserDefinedVMProperties='multiips=.*' --cver=4.0 and then restart ovirt-engine. Created attachment 1233353 [details]
/usr/libexec/vdsm/hooks/before_vm_start/multiips hook with debug output
*** Bug 1342784 has been marked as a duplicate of this bug. *** Please fill in the DOC TEXT and link to the feature page. The feature page http://www.ovirt.org/develop/release-management/features/network/networkfilterparameters/ should refer to the API doc http://ovirt.github.io/ovirt-engine-api-model/4.2/#services/nic_network_filter_parameters and mention that it is the only thing currently implemented. A rudimentary implementation of this (REST only) already exists in master (future 4.2), https://gerrit.ovirt.org/#/c/78045/ would give a test and an example for usage. UX may follow later. User can manage network filter parameters via REST-API and via UI.
Tested clean-traffic network filter scenario -
name - IP
value - x.x.x.z
Values passed as expected to the Libvirt XML -
<interface type='bridge'>
<mac address='00:00:00:00:00:23'/>
<source bridge='m3'/>
<target dev='vnet2'/>
<model type='virtio'/>
<filterref filter='clean-traffic'>
<parameter name='IP' value='x.x.x.x'/>
</filterref>
<boot order='2'/>
<alias name='net0'/>
Network filter parameters working as expected.
Verified on - 4.2.0-0.0.master.20170901193740.git7900511.el7.centos
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |