Bug 1367072

Summary: tags are not removed properly from filters when deactivated
Product: [oVirt] ovirt-engine Reporter: movciari
Component: Frontend.WebAdminAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: Lucie Leistnerova <lleistne>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.0.2.3CC: awels, bugs, lsvaty, oourfali, vszocs
Target Milestone: ovirt-4.1.0-betaFlags: rule-engine: ovirt-4.1+
rule-engine: planning_ack+
rule-engine: devel_ack+
lsvaty: testing_ack+
Target Release: 4.1.0.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-01 14:53:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
test UI plugin that will list the available tags, and which ones are active
none
test UI plugin that will list the available tags, and which ones are active none

Description movciari 2016-08-15 12:30:14 UTC 
Description of problem:
When you activate a tag in webadmin by clicking the pin, it adds the  tag=nameoftag filter to search for VMs, Hosts, and Users tab, and only shows VMs, Hosts, Users, and Dashboard tabs, all other tabs disappear

First problem: Dashboard tab doesn't work with tags (redirects to VMs tab when tag is active) and should be either removed from this view same way as other tabs that don't show when a tag is activated, or it should be fixed to work when a tag is activated

Second problem: when you deactivate tag when on VMs tab, and then go to Hosts tab, they are still filtered by tag. Deactivating tag should deactivate it for all tabs (as a workaround, you can just do the full refresh of page).

Version-Release number of selected component (if applicable):
rhevm 4.0.2.3

How reproducible:
always

Steps to Reproduce:
1. Click on pin next to name of tag in left pane to activate it - it should add the tag name to filter
2. Click on it again to deactivate it - it should remove the tag name from filter
3. Go to Hosts or Users tab

Actual results:
filter by tag shows up again

Expected results:
filter by tag should not show up

Additional info:
Can also be reproduced in 3.6
Comment 1 Vojtech Szocs 2016-12-15 18:04:28 UTC 
(In reply to movciari from comment #0)
> First problem: Dashboard tab doesn't work with tags (redirects to VMs tab
> when tag is active) and should be either removed from this view same way as
> other tabs that don't show when a tag is activated, or it should be fixed to
> work when a tag is activated

Indeed, Dashboard tab shouldn't be visible when a tag is active.

> Second problem: when you deactivate tag when on VMs tab, and then go to
> Hosts tab, they are still filtered by tag. Deactivating tag should
> deactivate it for all tabs (as a workaround, you can just do the full
> refresh of page).

IIRC, this is due to "remember search criteria per each tab" feature.
Comment 2 Alexander Wels 2017-01-05 20:49:13 UTC 
Created attachment 1237810 [details]
test UI plugin that will list the available tags, and which ones are active

Extract into /share/ovirt-engine/ui-plugins which will create tag_api directory and tag_api.json.

Then go to a tag and activate it. A popup will appear listing all the tags and an X marked which ones are active.
Comment 3 Alexander Wels 2017-01-09 16:33:16 UTC 
Created attachment 1238820 [details]
test UI plugin that will list the available tags, and which ones are active
Comment 4 Lucie Leistnerova 2017-01-26 14:22:57 UTC 
Dashboard tab is not included in filtering by tags.
Unpin removes filters from Hosts,VMs and Users.

verified in ovirt-engine-webadmin-portal-4.1.0.2-0.1.el7.noarch