Bug 1367265
| Summary: | Excessing logging - 'trying duplicate remote fd set' on fuse mount logfile - after rebalance completion | |||
|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Raghavendra G <rgowdapp> | |
| Component: | distribute | Assignee: | Raghavendra G <rgowdapp> | |
| Status: | CLOSED DEFERRED | QA Contact: | ||
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | mainline | CC: | atumball, bugs, kaushal, kramdoss, nbalacha, pkarampu, rcyriac, rgowdapp, rhinduja, rhs-bugs, sasundar, storage-qa-internal | |
| Target Milestone: | --- | Keywords: | Triaged | |
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | dht-rca-unknown, dht-rebalance-file, dht-log, dht-3.2.0-proposed, dht-retest | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 1172938 | |||
| : | 1367283 (view as bug list) | Environment: | ||
| Last Closed: | 2019-06-20 04:59:06 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1172938 | |||
| Bug Blocks: | 1367283 | |||
|
Description
Raghavendra G
2016-08-16 05:54:44 UTC
REVIEW: http://review.gluster.org/15462 (protocol/client: Destroy oldfdctx during a repeated open) posted (#1) for review on master by Raghavendra G (rgowdapp) patch [1] largely solves the in_progress/completion task races. However the fix is not complete as 1. the traversal of list of open fds on an inode is not a single atomic operation. 2. [1] doesn't track in-progress open and hence more than one open can be issued on same fd by racing in-progress-check/rebalance-completion-detection tasks. I can think of two possible solutions to this problem: 1. As mentioned in 2, tracking in-progress opens and waiting for them to complete before issuing open. However this requires to pause current task till in-progress open completes (as current fop cannot proceed till the fd is open). 2. Let the redundant opens be issued, but make sure protocol/client detect duplicate opens _and_ cleanup the fdctx, close the oldfd on brick, by calling client_fdctx_destroy on oldfdctx. We can implement both 1 and 2 to be more careful. @Nithya and others, Your inputs are required on possible approach. [1] http://review.gluster.org/12985 REVIEW: http://review.gluster.org/15462 (protocol/client: Destroy oldfdctx during a repeated open) posted (#2) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/15462 (protocol/client: Destroy oldfdctx during a repeated open) posted (#3) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/15462 (protocol/client: Destroy oldfdctx during a repeated open) posted (#4) for review on master by Raghavendra G (rgowdapp) REVIEW: http://review.gluster.org/15462 (protocol/client: Destroy oldfdctx during a repeated open) posted (#5) for review on master by Raghavendra G (rgowdapp) Not updated in last 3 years. Marking as DEFERRED to indicate the status. Will pick it up if found to be critical in next couple of months. |