Bug 1367272
| Summary: | [HC]: After bringing down and up of the bricks VM's are getting paused | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Krutika Dhananjay <kdhananj> |
| Component: | replicate | Assignee: | bugs <bugs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 3.8.2 | CC: | amukherj, bugs, mzywusko, pkarampu, rhs-bugs, rmekala, sabose, sasundar, storage-qa-internal |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.8.3 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1363721 | Environment: | |
| Last Closed: | 2016-08-24 10:21:04 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1333406, 1363721 | ||
| Bug Blocks: | 1367270 | ||
|
Description
Krutika Dhananjay
2016-08-16 06:14:57 UTC
REVIEW: http://review.gluster.org/15164 (cluster/afr: Bug fixes in txn codepath) posted (#1) for review on release-3.8 by Krutika Dhananjay (kdhananj) COMMIT: http://review.gluster.org/15164 committed in release-3.8 by Pranith Kumar Karampuri (pkarampu) ------ commit 62ad0bf74a97c20fb06161df3b2dd89f100bf617 Author: Krutika Dhananjay <kdhananj> Date: Fri Aug 5 12:18:05 2016 +0530 cluster/afr: Bug fixes in txn codepath Backport of: http://review.gluster.org/15145 AFR sets transaction.pre_op[] array even before actually doing the pre-op on-disk. Therefore, AFR must not only consider the pre_op[] array but also the failed_subvols[] information before setting the pre_op_done[] flag. This patch fixes that. Change-Id: I726b2acd4025e2e75a87dea547ca6e088bc82c00 BUG: 1367272 Signed-off-by: Krutika Dhananjay <kdhananj> Reviewed-on: http://review.gluster.org/15164 Reviewed-by: Ravishankar N <ravishankar> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Anuradha Talur <atalur> CentOS-regression: Gluster Build System <jenkins.org> There is one more patch that needs to go in, before this can be moved to MODIFIED. Changing the state to POST. REVIEW: http://review.gluster.org/15221 (cluster/afr: Prevent split-brain when bricks are brought off and on in cyclic order) posted (#1) for review on release-3.8 by Krutika Dhananjay (kdhananj) REVIEW: http://review.gluster.org/15221 (cluster/afr: Prevent split-brain when bricks are brought off and on in cyclic order) posted (#2) for review on release-3.8 by Oleksandr Natalenko (oleksandr) REVIEW: http://review.gluster.org/15221 (cluster/afr: Prevent split-brain when bricks are brought off and on in cyclic order) posted (#3) for review on release-3.8 by Krutika Dhananjay (kdhananj) COMMIT: http://review.gluster.org/15221 committed in release-3.8 by Pranith Kumar Karampuri (pkarampu) ------ commit d99f72842595306e9f26a275804bf0f310caba53 Author: Krutika Dhananjay <kdhananj> Date: Thu Jul 28 21:29:59 2016 +0530 cluster/afr: Prevent split-brain when bricks are brought off and on in cyclic order Backport of: http://review.gluster.org/15080 When the bricks are brought offline and then online in cyclic order while writes are in progress on a file, thanks to inode refresh in write txns, AFR will mostly fail the write attempt when the only good copy is offline. However, there is still a remote possibility that the file will run into split-brain if the brick that has the lone good copy goes offline *after* the inode refresh but *before* the write txn completes (I call it in-flight split-brain in the patch for ease of reference), requiring intervention from admin to resolve the split-brain before the IO can resume normally on the file. To get around this, the patch does the following things: i) retains the dirty xattrs on the file ii) avoids marking the last of the good copies as bad (or accused) in case it is the one to go down during the course of a write. iii) fails that particular write with the appropriate errno. This way, we still have one good copy left despite the split-brain situation which when it is back online, will be chosen as source to do the heal. > Change-Id: I9ca634b026ac830b172bac076437cc3bf1ae7d8a > BUG: 1363721 > Signed-off-by: Krutika Dhananjay <kdhananj> > Reviewed-on: http://review.gluster.org/15080 > Tested-by: Pranith Kumar Karampuri <pkarampu> > Smoke: Gluster Build System <jenkins.org> > CentOS-regression: Gluster Build System <jenkins.org> > Reviewed-by: Ravishankar N <ravishankar> > Reviewed-by: Oleksandr Natalenko <oleksandr> > NetBSD-regression: NetBSD Build System <jenkins.org> > Reviewed-by: Pranith Kumar Karampuri <pkarampu> (cherry picked from commit fcb5b70b1099d0379b40c81f35750df8bb9545a5) Change-Id: I157f1025aebd6624fa3d412abc69a4ae6f2fe9e0 BUG: 1367272 Signed-off-by: Krutika Dhananjay <kdhananj> Signed-off-by: Oleksandr Natalenko <oleksandr> Reviewed-on: http://review.gluster.org/15221 NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Smoke: Gluster Build System <jenkins.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.3, please open a new bug report. glusterfs-3.8.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://www.gluster.org/pipermail/announce/2016-August/000059.html [2] https://www.gluster.org/pipermail/gluster-users/ |