| Summary: | Add an option to always show the background logo | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Olivier Samyn <code> | ||||||
| Component: | gnome-shell-extension-background-logo | Assignee: | Florian Müllner <fmuellner> | ||||||
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | fmuellner, klember | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-09-13 20:35:18 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Attachments: |
|
||||||||
(In reply to Olivier Samyn from comment #0) > The proposed patch just adds a custom setting and a corresponding switch in > the extension preferences dialog. Thanks for that! To be honest, the preferences just exist so the Fedora designers could figure out the settings they liked best without fiddling with the code, but I'm not opposed to add this setting. But please make it look decent - the oversized switch is horrible! Not setting the halign value to FILL helps, though I wonder whether a CheckButton that spans both columns would be more appropriate. The setting should also use a better label - "Always visible" is not at all clear, something like "Show for all backgrounds" conveys the meaning much better IMHO. Created attachment 1200455 [details]
Path v2: replaced the switch with a check button + label
First, It's nice this option can be merged, thanks for this.
I replaced the switch with a check button + label aligned with the other controls (does not span over the existing label column).
Let me know if this solution is less ugly than the switch box.
Otherwise, I can also try make a centered switch.
I also used the more generic "Show for all backgrounds" label.
Merged with some minor tweaks, thanks. |
Created attachment 1191488 [details] Add an always visible setting Description of problem: Even if the original extension purpose is to add the fedora logo on the default wallpaper, there are requests to add a little bit of branding on top of custom wallpapers. Because we are proud of our distribution, let's add an option to always show it's name. The proposed patch just adds a custom setting and a corresponding switch in the extension preferences dialog.