Bug 1367700

Summary: Display a warning if user tries to create multiple bricks on the same server during replace-brick.
Product: [oVirt] ovirt-engine Reporter: RamaKasturi <knarra>
Component: BLL.GlusterAssignee: Gobinda Das <godas>
Status: CLOSED CURRENTRELEASE QA Contact: SATHEESARAN <sasundar>
Severity: low Docs Contact:
Priority: medium    
Version: 4.0.2.6CC: bugs, godas, lveyde, sabose, sasundar
Target Milestone: ovirt-4.2.0Flags: rule-engine: ovirt-4.2+
rule-engine: planning_ack+
rule-engine: devel_ack+
sasundar: testing_ack+
Target Release: 4.1.9   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.1.9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-10 06:31:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Attaching screenshot for replace brick none

Description RamaKasturi 2016-08-17 09:13:41 UTC 
Description of problem:
There is no warning message displayed as of now if user tries to create multiple bricks on the same server during replace-brick.

Version-Release number of selected component (if applicable):
ovirt-engine-4.0.2.6-0.1.el7ev.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create a volume of replica 3 say s1:/b1, s2:/b2 , s3:/b3
2. Now click on replace-brick and select s1 from the Host and select brick from Brick Directory.
3.Click ok

Actual results:
Brick gets replaced.

Expected results:
Replacing of brick should ask for a confirmation  which says that the setup is not optimal since multiple bricks are on the same server. Do you want to continue ?

Additional info:
Comment 1 Sandro Bonazzola 2017-10-20 06:11:46 UTC 
Sahina, this is not marked as a blocker, please either block 4.1.7 or push to 4.1.8.
Comment 2 RamaKasturi 2017-11-27 17:14:03 UTC 
Hi Gobinda,

       I tried to replace a brick in  replicate volume with the same server and i do not see UI displaying any warning for the same. Below are the versions of RHV-M and vdsm i am using. Can you please confirm ?

Attaching the screenshot for the same.

RHV-M : Red Hat Virtualization Manager Version: 4.1.8.1-0.1.el7

vdsm : vdsm-4.19.40-1.el7ev.x86_64
Comment 3 RamaKasturi 2017-11-27 17:14:37 UTC 
Created attachment 1359570 [details]
Attaching screenshot for replace brick
Comment 4 Gobinda Das 2017-11-29 05:52:58 UTC 
Hi Kasturi,
 The changes happen in master branch and for that I wrote lambda expression and stream api which is supported by jdk8 but backport 4.1 branch does not support jdk8, so i changed backport code to normal code.
But I am surprised the working code is still in my local,I really don't know how it did not push.
I am really sorry for that.
Please fail QA and we can retarget it to 4.1.9.
Comment 5 RamaKasturi 2017-11-29 05:58:20 UTC 
Cool, thanks gobinda for confirming.

Based on comment 2 and comment 4 moving marking this as failed qa.
Comment 6 Sahina Bose 2017-11-29 08:09:55 UTC 
Retargeting to 4.1.9
Comment 7 RamaKasturi 2018-01-22 13:59:55 UTC 
Hello gobinda,

      I still see that there is no warning thrown while replacing bricks from same server. Am i missing something here ?

Below is the RHV version i have : Red Hat Virtualization Manager Version: 4.1.9.1-0.1.el7

[root@hostedenginesm2 ~]# rpm -qa | grep ovirt-engine
ovirt-engine-dashboard-1.1.8-1.el7ev.noarch
ovirt-engine-setup-plugin-ovirt-engine-common-4.1.9.1-0.1.el7.noarch
ovirt-engine-websocket-proxy-4.1.9.1-0.1.el7.noarch
ovirt-engine-userportal-4.1.9.1-0.1.el7.noarch
ovirt-engine-sdk-python-3.6.9.1-1.el7ev.noarch
ovirt-engine-setup-plugin-vmconsole-proxy-helper-4.1.9.1-0.1.el7.noarch
ovirt-engine-4.1.9.1-0.1.el7.noarch
ovirt-engine-extension-aaa-ldap-setup-1.3.6-1.el7ev.noarch
ovirt-engine-lib-4.1.9.1-0.1.el7.noarch
ovirt-engine-setup-plugin-ovirt-engine-4.1.9.1-0.1.el7.noarch
ovirt-engine-setup-plugin-websocket-proxy-4.1.9.1-0.1.el7.noarch
ovirt-engine-vmconsole-proxy-helper-4.1.9.1-0.1.el7.noarch
ovirt-engine-restapi-4.1.9.1-0.1.el7.noarch
ovirt-engine-backend-4.1.9.1-0.1.el7.noarch
ovirt-engine-sdk-java-3.6.8.0-1.el7ev.noarch
python-ovirt-engine-sdk4-4.1.5-1.el7ev.x86_64
ovirt-engine-dwh-setup-4.1.9-1.el7ev.noarch
ovirt-engine-setup-4.1.9.1-0.1.el7.noarch
ovirt-engine-extensions-api-impl-4.1.9.1-0.1.el7.noarch
ovirt-engine-webadmin-portal-4.1.9.1-0.1.el7.noarch
ovirt-engine-dwh-4.1.9-1.el7ev.noarch
java-ovirt-engine-sdk4-4.1.3-1.el7ev.noarch
ovirt-engine-cli-3.6.8.1-1.el7ev.noarch
ovirt-engine-tools-backup-4.1.9.1-0.1.el7.noarch
ovirt-engine-tools-4.1.9.1-0.1.el7.noarch
ovirt-engine-extension-aaa-ldap-1.3.6-1.el7ev.noarch
ovirt-engine-setup-base-4.1.9.1-0.1.el7.noarch
ovirt-engine-metrics-1.0.5-1.el7ev.noarch
ovirt-engine-dbscripts-4.1.9.1-0.1.el7.noarch
ovirt-engine-extension-aaa-jdbc-1.1.6-1.el7ev.noarch

Thanks
kasturi
Comment 8 SATHEESARAN 2018-01-24 02:23:14 UTC 
(In reply to RamaKasturi from comment #7)
> Hello gobinda,
> 
>       I still see that there is no warning thrown while replacing bricks
> from same server. Am i missing something here ?
> 
> Below is the RHV version i have : Red Hat Virtualization Manager Version:
> 4.1.9.1-0.1.el7
> 
> [root@hostedenginesm2 ~]# rpm -qa | grep ovirt-engine
> ovirt-engine-dashboard-1.1.8-1.el7ev.noarch
> ovirt-engine-setup-plugin-ovirt-engine-common-4.1.9.1-0.1.el7.noarch
> ovirt-engine-websocket-proxy-4.1.9.1-0.1.el7.noarch
> ovirt-engine-userportal-4.1.9.1-0.1.el7.noarch
> ovirt-engine-sdk-python-3.6.9.1-1.el7ev.noarch
> ovirt-engine-setup-plugin-vmconsole-proxy-helper-4.1.9.1-0.1.el7.noarch
> ovirt-engine-4.1.9.1-0.1.el7.noarch
> ovirt-engine-extension-aaa-ldap-setup-1.3.6-1.el7ev.noarch
> ovirt-engine-lib-4.1.9.1-0.1.el7.noarch
> ovirt-engine-setup-plugin-ovirt-engine-4.1.9.1-0.1.el7.noarch
> ovirt-engine-setup-plugin-websocket-proxy-4.1.9.1-0.1.el7.noarch
> ovirt-engine-vmconsole-proxy-helper-4.1.9.1-0.1.el7.noarch
> ovirt-engine-restapi-4.1.9.1-0.1.el7.noarch
> ovirt-engine-backend-4.1.9.1-0.1.el7.noarch
> ovirt-engine-sdk-java-3.6.8.0-1.el7ev.noarch
> python-ovirt-engine-sdk4-4.1.5-1.el7ev.x86_64
> ovirt-engine-dwh-setup-4.1.9-1.el7ev.noarch
> ovirt-engine-setup-4.1.9.1-0.1.el7.noarch
> ovirt-engine-extensions-api-impl-4.1.9.1-0.1.el7.noarch
> ovirt-engine-webadmin-portal-4.1.9.1-0.1.el7.noarch
> ovirt-engine-dwh-4.1.9-1.el7ev.noarch
> java-ovirt-engine-sdk4-4.1.3-1.el7ev.noarch
> ovirt-engine-cli-3.6.8.1-1.el7ev.noarch
> ovirt-engine-tools-backup-4.1.9.1-0.1.el7.noarch
> ovirt-engine-tools-4.1.9.1-0.1.el7.noarch
> ovirt-engine-extension-aaa-ldap-1.3.6-1.el7ev.noarch
> ovirt-engine-setup-base-4.1.9.1-0.1.el7.noarch
> ovirt-engine-metrics-1.0.5-1.el7ev.noarch
> ovirt-engine-dbscripts-4.1.9.1-0.1.el7.noarch
> ovirt-engine-extension-aaa-jdbc-1.1.6-1.el7ev.noarch
> 
> Thanks
> kasturi

Gobinda,

Based on comment7, looks like this issue is **not** fixed correctly with RHV 4.1.9. Marking this bug to ASSIGNED
Comment 9 Sahina Bose 2018-01-24 05:31:41 UTC 
Retargeting this to RHV 4.2 as it's not a high priority bug
Comment 10 Gobinda Das 2018-02-05 12:56:57 UTC 
I wonder how it's not working?I verified multiple times in local before push patch.Anyways I will cross check.
Comment 11 SATHEESARAN 2018-05-10 02:25:31 UTC 
Tested with RHV 4.2.3 and gluster-3.12

1. When the brick is replaced with brick from the same host, proper warning message is thrown:

"The setup is not optimal since multiple bricks are on the same server. Do you want to continue?"
Comment 12 Sandro Bonazzola 2018-05-10 06:31:19 UTC 
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.