| Summary: | startin team slave when master has invalid json config leads to infinite connecting state | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Vladimir Benes <vbenes> |
| Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 7.3 | CC: | atragler, bgalvani, dcbw, desktop-qa-list, lkundrak, lrintel, rkhan, thaller, vbenes, vhumpa |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | NetworkManager-1.8.0-0.2.git20170215.1d40c5f4.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1270814 | Environment: | |
| Last Closed: | 2017-08-01 09:17:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1270814 | ||
| Bug Blocks: | |||
|
Comment 2
Beniamino Galvani
2016-08-26 07:51:11 UTC
>> libnm: make waiting objects fail when an object initialization fails
+ priv->waiters = g_slist_remove (priv->waiters, odata);
g_slist_delete_link?
NM_OBJECT_GET_PRIVATE (odata->self)->reload_error = g_error_copy (error);
are we sure, that this doesn't leak a possible previously set error? Maybe:
if (!odata_priv->reload_error)
...
rest lgtm
(In reply to Thomas Haller from comment #3) > + priv->waiters = g_slist_remove (priv->waiters, odata); > > g_slist_delete_link? I prefer to leave it similar to the code few lines below. > NM_OBJECT_GET_PRIVATE (odata->self)->reload_error = g_error_copy (error); > > are we sure, that this doesn't leak a possible previously set error? Maybe: > > if (!odata_priv->reload_error) Fixed, thanks! Looks fine to me. Branch merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=aae26ebed31a8195f8b11b015ae77a45c753e5d3 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:2299 |