Bug 1367976

Summary:	Review Request: rubygem-contracts - Contracts for Ruby
Product:	[Fedora] Fedora	Reporter:	Mamoru TASAKA <mtasaka>
Component:	Package Review	Assignee:	Vít Ondruch <vondruch>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, vondruch
Target Milestone:	---	Flags:	vondruch: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-10 09:19:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1365872

Description Mamoru TASAKA 2016-08-18 03:19:31 UTC

Spec URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-contracts.spec
SRPM URL: https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-contracts-0.14.0-1.fc.src.rpm
Description: 
This library provides contracts for Ruby. Contracts let you clearly express
how your code behaves, and free you from writing tons of boilerplate,
defensive code.
Fedora Account System Username: mtasaka

scratch build
For F-26: http://koji.fedoraproject.org/koji/taskinfo?taskID=15291487

Comment 1 Vít Ondruch 2016-09-02 11:18:18 UTC

I'll take this for a review.

Comment 2 Vít Ondruch 2016-09-02 11:29:39 UTC

Generally, the package looks ok => I APPROVE the package.


Nevertheless, there are few nits I'd like to clarify:

* Integration test suite
  - Have you tried to execute the integration test suite?

* Keeping the integration test suite around
  - You remove quite a lot of stuff from the package, including the test suite.
    Nevertheless, you keep around the test suite (features folder). I am
    wondering what is the reason for this?

Comment 3 Mamoru TASAKA 2016-09-02 13:06:13 UTC

Thank you for initial comments!

* Integration test suite
  - Well, there is "rspec spec/" in spec file, do you mean other
    test suite here?

* > you keep around the test suite (features folder)
  - Well, I think "features" directory explains the "feature" of this
    gem, i.e. quite similar with "examples".
    For example, "features/basics/simple_example.feature" explains the
    basic usage of this gem.

Comment 4 Vít Ondruch 2016-09-02 20:04:26 UTC

(In reply to Mamoru TASAKA from comment #3)
> Thank you for initial comments!

I said I approve the package but forgot to set review+, sorry ...



> * Integration test suite
>   - Well, there is "rspec spec/" in spec file, do you mean other
>     test suite here?
> 
> * > you keep around the test suite (features folder)
>   - Well, I think "features" directory explains the "feature" of this
>     gem, i.e. quite similar with "examples".
>     For example, "features/basics/simple_example.feature" explains the
>     basic usage of this gem.


Actually, these two bullets are more or less one bullet then, since the features directory contains the test suite in question if I am not mistaken. That should be executable using Cucumber. In theory, calling "cucumber" command should be enough to execute it.

Comment 5 Mamoru TASAKA 2016-09-07 09:59:04 UTC

Okay, thank you. I will look at features/ directory later. And thank you for approving!

Comment 6 Gwyn Ciesla 2016-09-07 12:26:44 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-contracts

Comment 7 Mamoru TASAKA 2016-09-10 09:19:11 UTC

Imported into rawhide. thank you!