Bug 1368031

Summary: The instruction in haproxy-config.template is incomplete
Product: OpenShift Container Platform Reporter: Meng Bo <bmeng>
Component: NetworkingAssignee: Ben Bennett <bbennett>
Networking sub component: router QA Contact: Meng Bo <bmeng>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: low CC: aos-bugs, bperkins, pweil, tdawson
Version: 3.3.0   
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Comment in template was incomplete. Consequence: People reading the template would be confused. Fix: Complete the comment. Result: Less confusion.
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-27 09:44:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Meng Bo 2016-08-18 07:39:16 UTC
Description of problem:
Check the haproxy-config.template and find the "app level backend" section,
The 3rd point in the instruction is incomplete.

https://github.com/openshift/origin/blob/master/images/router/haproxy/conf/haproxy-config.template#L230

Version-Release number of selected component (if applicable):
3.3.0.22

How reproducible:
always

Steps to Reproduce:
1. Check the haproxy-config.template
2.
3.

Actual results:
The instruction is incomplete.

Expected results:


Additional info:

Comment 1 openshift-github-bot 2016-08-18 22:09:24 UTC
Commit pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/c0b7f664db8ea9b0a62c989b4d79a83cc480e3b9
Fixed the comment about the different backends we make

Filled in the rest of the comment about the pass-through case.  Made
the comment cover the additional edge termination case.  Clarified the
wording to make it clear what happens for each termination type.

Fixes bug 1368031

Comment 2 Troy Dawson 2016-09-01 15:58:31 UTC
This has been merged into ose and is in OSE v3.3.0.28 or newer.

Comment 4 Meng Bo 2016-09-02 05:50:35 UTC
Checked on router image openshift3/ose-haproxy-router:v3.3.0.28 6ff97e2fd698

Issue has been fixed.

Comment 6 errata-xmlrpc 2016-09-27 09:44:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1933