Bug 1368056

Summary: [3.13.2] Assertion in prefs_gtk.c:79 Condition label != NULL failed
Product: [Fedora] Fedora Reporter: Ali Akcaagac <aliakc>
Component: claws-mailAssignee: Andreas Bierfert <andreas.bierfert>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: andreas.bierfert, bugs.michael, kupo
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-08 16:36:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
claws-mail error log none

Description Ali Akcaagac 2016-08-18 08:55:30 UTC
Yesterday I ran into an problematic issue with claws-mail 3.13.2 on Fedora 24. I wanted to create a new Folder in my Inbox-Tree (POP3 local within ~/Mail folder). This caused claws-mail to trigger a GTK+ stacktrace. Though the new folder is created correctly, this still leaves a bitter taste of trustworthiness. I tried reproducing this issue again today but wasn't reproducable.

Then I went over to claws-mail site and saw a new release of claws-mail 3.14.0 which claims to have fixed numerous out of bounds issues. segfaults and heap issues. Besides other things.

It might make sense to ask for an updated claws-mail 3.14.0 for Fedora 24 and upwards, so I can investigate this behaviour within a new version - rather than investigating weeks into an old version (released in january) which bug might have been fixed already.

Comment 1 Michael Schwendt 2016-08-18 15:05:41 UTC
> It might make sense to ask for an updated claws-mail 3.14.0 for
> Fedora 24 and upwards, 

So what? 3.14.0 has been released on August 7th, and typically the first Fedora builds are published for Rawhide first. That has happened very quickly:

  http://koji.fedoraproject.org/koji/packageinfo?packageID=1474

Comment 2 Ali Akcaagac 2016-09-20 09:24:11 UTC
(In reply to Michael Schwendt from comment #1)
> So what? 3.14.0 has been released on August 7th, and typically the first
> Fedora builds are published for Rawhide first. That has happened very
> quickly:

Thanks for the feedback.

I didn't wanted to go into details here and only reported an issue with claws-mail 3.13.0, where it generate GTK+ stacktrace issues on the terminal, during new folder generation within claws-mail.

My report was just an *RFE* to ask for an update for Fedora 24 (not rawhide). I also don't follow every happenings on Fedora that closely, therefore I wasn't aware of the link you posted:

> http://koji.fedoraproject.org/koji/packageinfo?packageID=1474

Though the GTK+ stacktrace issue still exists and that update might solve it. I can only test this, if a new version is made available. If I'd reported an issue with 3.13.0 to upstream, then they might tell me to report bugs for the latest release because the issues might have been solved already.

Comment 3 Michael Schwendt 2016-09-22 09:14:47 UTC
> Though the GTK+ stacktrace issue still exists and that update might solve it.

Earlier you wrote:

> I tried reproducing this issue again today but wasn't reproducable.

Is it reproducible or not? What are the steps on how to reproduce it?

Comment 4 Ali Akcaagac 2016-09-22 11:05:00 UTC
(In reply to Michael Schwendt from comment #3)
> Is it reproducible or not? What are the steps on how to reproduce it?

It is! But it's hard to reproduce - Luckely I was able to catch that one again a few moments ago, during my own attempt to re-produce it again.

The problem is, it's really hard to trigger.

Maybe it helps how I did this:

1) Start a new claws-mail instance (from Terminal and pipe the output to a file). No old Preferences or ~/Mail folders.

2) Walk through the first time Account generator by clicking Next, Next, ... until you get into the main claws-mail window.

3) Now the tricky part. Start creating, moving, deleting, re-creating new mail folders. You can do this anywhere "Inbox", "Sent", "Drafts", even generate new Folders from the Root and even Folders inside Folders. Delete, move and re-create them.

4) Maybe you might want to run a tail -f on the log that you created by starting claws-mail and piped to the log (&>).

5) It can take a while but you might end up catching a backtrace like the one I've attached.

The first time I hit this, the bug appeared when I created only "one" new Folder inside a tree of subfolders (for my personal mail organization). Then after that, the problem comes up every now and then - but I never logged it into a file or so because I was never prepared to go bug hunting.

But the log should give some idea.

Comment 5 Ali Akcaagac 2016-09-22 11:05:39 UTC
Created attachment 1203684 [details]
claws-mail error log

Comment 6 Michael Schwendt 2016-09-22 19:00:21 UTC
Not simply attaching the automated backtrace created by the ABRT tool complicates matters. The backtrace you've created lacks all the details because the needed -debuginfo packages are not installed.

I would not call it "a GTK+ stacktrace", because the actual crash is due to  failing a developer's assertion in claws-mail/src/prefs_gtk.c, which means whatever you've done managed to break Claws Mail by running into a completely unexpected condition (a NULL pointer in this place is nothing the code tries to handle anymore, it is fatal).

> prefs_gtk.c:79 Condition label != NULL failed

    77  
    78          cm_return_if_fail(param != NULL);
    79          cm_return_if_fail(label != NULL);
    80          cm_return_if_fail(rcfile != NULL);
    81  

What you refer to as "tricky part" is much too vague. It could be anything. The speed of creating/moving/deleting folders could lead to a race condition somewhere (such as in GUI callbacks).

Nothing in the Claws Mail 3.14.0 NEWS mentions a bug-fix/change related to this area.

Comment 7 Fedora End Of Life 2017-07-25 22:29:58 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 8 Fedora End Of Life 2017-08-08 16:36:35 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.