| Summary: | Review Request: libgnome-games-support - Support library for GNOME games | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanko Kaneti <yaneti> |
| Component: | Package Review | Assignee: | Kalev Lember <klember> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | klember, package-review |
| Target Milestone: | --- | Flags: | klember:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-18 13:29:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Yanko Kaneti
2016-08-18 11:08:38 UTC
I would also add obsoletes to both libgnome-games-support and libgnome-games-support-devel so that the old package gets removed on upgrade. There's only a handful of consumers and they'll all get ported this cycle. Something like, Obsoletes: libgames-support < 1.1.90 and Obsoletes: libgames-support-devel < 1.1.90 - 1.1.90-2 - Add libgames-support obsoltes Spec URL: http://declera.com/~yaneti/libgnome-games-support/libgnome-games-support.spec SRPM URL: http://declera.com/~yaneti/libgnome-games-support/libgnome-games-support-1.1.90-2.fc26.src.rpm Fedora review libgnome-games-support-1.1.90-1.fc26.src.rpm 2016-08-18
$ rpmlint libgnome-games-support-1.1.90-1.fc26.src.rpm \
libgnome-games-support \
libgnome-games-support-devel \
libgnome-games-support-debuginfo
libgnome-games-support.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgnome-games-support-1.0.so.2.0.1 /lib64/libpangocairo-1.0.so.0
libgnome-games-support.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgnome-games-support-1.0.so.2.0.1 /lib64/libpango-1.0.so.0
libgnome-games-support.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgnome-games-support-1.0.so.2.0.1 /lib64/libatk-1.0.so.0
libgnome-games-support.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgnome-games-support-1.0.so.2.0.1 /lib64/libcairo-gobject.so.2
libgnome-games-support.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgnome-games-support-1.0.so.2.0.1 /lib64/libcairo.so.2
libgnome-games-support.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgnome-games-support-1.0.so.2.0.1 /lib64/libgdk_pixbuf-2.0.so.0
libgnome-games-support-devel.x86_64: W: only-non-binary-in-usr-lib
libgnome-games-support-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 8 warnings.
+ OK
! needs attention
+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (COPYING.LESSER) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
c8232181fd5d82a73377e55caf50a87c libgnome-games-support-1.1.90.tar.xz
c8232181fd5d82a73377e55caf50a87c Download/libgnome-games-support-1.1.90.tar.xz
+ The package builds in koji (http://koji.fedoraproject.org/koji/taskinfo?taskID=15294834)
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ locale handling
+ ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
+Obsoletes: libgames-support < 1.1.90 +Obsoletes: libgames-support-devel < 1.1.90 + Maybe move the second one to the -devel subpackage? Beyond that, looks good to me now, thanks! APPROVED - 1.1.90-3 - Move libgames-support-devel obsoletes to -devel Spec URL: http://declera.com/~yaneti/libgnome-games-support/libgnome-games-support.spec SRPM URL: http://declera.com/~yaneti/libgnome-games-support/libgnome-games-support-1.1.90-3.fc26.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libgnome-games-support Built in rawhide and f25. Schedulled for the f25 megaupdate. Closing Thanks |