| Summary: | Review Request: python-pika-pool - Pools for pikas (rename of python-pika_pool) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Javier Peña <jpena> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | karlthered, package-review, projects.rg, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-02-13 22:22:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Javier Peña
2016-08-18 14:31:55 UTC
Please change Summary to something meaningful. Define %global _description \ blah blah ... \ blah blah and then use it as %description %_description, %description -n python3-pika-pool %_description, %description -n python2-pika-pool %_description. The version in Obsoletes is supposed to be fixed, e.g. < 0.1.3-5, see https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages. Thanks for the review. I have uploaded the updates files to the same location: Spec URL: https://jpena.fedorapeople.org/python-pika-pool/python-pika-pool.spec SRPM URL: https://jpena.fedorapeople.org/python-pika-pool/python-pika-pool-0.1.3-5.fc26.src.rpm Haïkel? Are you still interested in doing this review? Second friendly reminder. Must have fallen of the radar. I'll take over the review. + package name is OK + license is acceptable (BSD) + license is specified correctly + P/R/BR look correct + modern python packaging template is used + %python_provides are present + builds and installs OK + fedora-review has no complaints + rpmlint only has bogus spelling fixes Package is APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pika-pool Please build for Fedora 25 at least, too. python-pika-pool-0.1.3-6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-258d703865 python-pika-pool-0.1.3-6.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-258d703865 python-pika-pool-0.1.3-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-pika-pool-0.1.3-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |