Bug 1368351

Summary: virsh migrate option --rdma-pin-all is missing in virsh man page
Product: Red Hat Enterprise Linux 7 Reporter: Fangge Jin <fjin>
Component: libvirtAssignee: Jiri Denemark <jdenemar>
Status: CLOSED ERRATA QA Contact: Yanqiu Zhang <yanqzhan>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: dyuan, jdenemar, mzhan, rbalakri, xuzhang, yafu, yanqzhan, zpeng
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-2.5.0-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 17:11:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fangge Jin 2016-08-19 07:21:56 UTC
Description of problem:
virsh migrate option --rdma-pin-all exists in the output of virsh help
, but it is missing in virsh man page.

Version-Release number of selected component:
libvirt-2.0.0-5.el7.x86_64

How reproducible:
100%

Steps:
1. # virsh migrate --help|grep rdma
    --rdma-pin-all   support memory pinning during RDMA live migration

2. # man virsh
  
3. Search rdma in "man virsh"

Actual results:
No description for --rdma-pin-all in virsh man page

Expected results:
Add description for --rdma-pin-all in virsh man page

Comment 2 Jiri Denemark 2016-11-22 20:35:47 UTC
This is now fixed upstream by

commit 29dc9a52d78b09cafbb3b2cd20f13d38fb258181
Refs: v2.4.0-185-g29dc9a52d
Author:     Jiri Denemark <jdenemar>
AuthorDate: Tue Nov 22 19:26:45 2016 +0100
Commit:     Jiri Denemark <jdenemar>
CommitDate: Tue Nov 22 21:32:54 2016 +0100

    virsh: Document --rdma-pin-all migrate option properly

    https://bugzilla.redhat.com/show_bug.cgi?id=1368351

    Signed-off-by: Jiri Denemark <jdenemar>

Comment 4 Yanqiu Zhang 2017-02-03 07:49:12 UTC
Reproduce this bug with on libvirt-2.0.0-10.el7.x86_64
  No description for --rdma-pin-all in virsh man page

Verify this bug with libvirt-2.5.0-1.el7.x86_64
  Search rdma in "man virsh", following description are included: 

      migrate [--live]......[--rdma-pin-all] ......

           --rdma-pin-all can be used with RDMA migration (i.e., when
           migrateuri starts with rdma://) to tell the hypervisor to pin all
           domain's memory at once before migration starts rather then letting
           it pin memory pages as needed.


Since the result is as expected, mark this bug as verified.

Comment 5 errata-xmlrpc 2017-08-01 17:11:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846

Comment 6 errata-xmlrpc 2017-08-01 23:53:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846