Bug 1368352
| Summary: | /tmp/packaging.log is not uploaded if Anaconda hits an error before mounting /mnt/sysimage | ||
|---|---|---|---|
| Product: | [Retired] Beaker | Reporter: | Jan Stodola <jstodola> |
| Component: | reports | Assignee: | Dan Callaghan <dcallagh> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | tools-bugs <tools-bugs> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 23 | CC: | dcallagh, dowang, mjia, rjoost |
| Target Milestone: | 23.2 | Keywords: | Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-09-02 07:01:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jan Stodola
2016-08-19 07:25:01 UTC
/tmp/packaging.log is already on the list of files monitored by anamon, so it should be being uploaded, hmm... Oh I think I got it. In sys.log I noticed: 10:53:13,533 INFO chronyd: Selected source 10.5.27.10 10:53:13,533 WARNING chronyd: System clock wrong by 14400.007768 seconds, adjustment started 14:53:13,541 WARNING chronyd: System clock was stepped by 14400.007768 seconds I wondered, in anamon are we sensitive to clock warps? Yes, we are. MountWatcher checks time.time() as part of its logic for looking in /proc/mounts -- it waits until the line for /mnt/sysimage has been present in the file for more than 60 seconds after it was first seen. But if the clock warps backwards in between the time the line was first seen, and before the 60 second wait has succeeded, it will end up waiting for hours instead. Surely that makes no difference to /tmp/packaging.log, which doesn't need to wait for /mnt/sysimage to appear... but it does, because /tmp/packaging.log was added to the wrong list. http://gerrit.beaker-project.org/5156 anamon: /tmp/packaging.log doesn't need to wait for /mnt/sysimage Dunno about my chances of successfully reproducing this or proving that it's fixed though, hmm... Also not sure how to fix the problem of anamon being sensitive to clock warping... Python added a monotonic clock in 3.3 but that doesn't help us on any RHELs. Even some craziness like this: http://stackoverflow.com/a/1205762/120202 won't work on RHEL <= 5 due to missing ctypes. And I wouldn't really be keen to have some mess like that in anamon anyway. (In reply to Dan Callaghan from comment #3) Actually not sure if this theory holds water anyway, since in that case the clock was being warped *forwards* not backwards so it wouldn't have prevented anamon from considering the mount as stable. The explanation could be simpler... Anaconda might have never mounted /mnt/sysimage because it bailed out with an error before it reached that point. One way to get Anaconda to bail out with an error before mounting /mnt/sysimage is to just add a deliberately broken %packages section -- although it doesn't reproduce the exact same Anaconda error condition as in the recipe in comment 1. <ks_appends> <ks_append> %packages doesnotexist %end </ks_append> </ks_appends> Expected result: Anaconda errors out of the installation. packaging.log should appear in the recipe logs. Actual result: Anaconda errors out of the installation, but packaging.log is not present in Beaker. Confirmed that the patch in comment 4 fixes this. Beaker 23.2 has been released. |