Bug 1368372

Summary:	[RFE] Wait interval 60000 (60s) is too short for openshiftDeploy stage in jenkins master image
Product:	OpenShift Container Platform	Reporter:	Xingxing Xia <xxia>
Component:	ImageStreams	Assignee:	Gabe Montero <gmontero>
Status:	CLOSED ERRATA	QA Contact:	Wang Haoran <haowang>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.3.0	CC:	aos-bugs, bparees, jokerman, mmccomas, tdawson
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Feature: Change the default deployment timeout from 1 minute to 10 minutes in the OpenShift Pipeline Plugin for Jenkins. Reason: Deployments with prehooks and liveness/readiness probes were typically taking more than 1 minute. Result: Users of the OpenShift Pipeline Plugin for Jenkins had to change the deployment timeout setting less often.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-27 09:10:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Xingxing Xia 2016-08-19 08:30:21 UTC

Description of problem:
In jenkins web console, its '/configure' page shows Wait interval value 60000 (unit: ms. = 60s) for deployment to complete. But after "oc start-build sample-pipeline", the deploy stage often takes more than 60s, which causes the pipeline build "Failed".
This value is too short, considering that DC often has prehook, living/readiness probes besides starting container up, the total time of which can easily exceed 60s.
Though user can set it in '/configure' or somewhere else, it is better to let the jenkins master image have an greater initial value, e.g. to "600s", because under dc's spec.strategy, timeoutSeconds is also 600s by default.

Version-Release number of selected component (if applicable):
openshift3/jenkins-1-rhel7 image id: b6e3a2eefe4b

How reproducible:
Always

Steps to Reproduce:
1. Visit jenkins web console '/configure' page , click "Manage Jenkins" -> "Configure System", find 60000, the 'Wait interval' value for deployment to complete
2.
3.

Actual results:
1. The value is too short

Expected results:
2. Better to make the value greater, e.g. 600s

Additional info:

Comment 3 Gabe Montero 2016-08-19 15:30:36 UTC

OK, have the change to bump to 600s with commit https://github.com/openshift/jenkins-plugin/commit/cb47a7eb15ac9d60873945367e3f2921f3423fb1

However, NOTE, to actually receive this change, we need to bump the plugin version on JenkinsCI, and then have an RPM build for the new version, and then gen a new Jenkins RHEL image and have it push through to brew-pulp, etc.

Ben and I talked and we'll do this after 3.3 ships.

Comment 4 Gabe Montero 2016-08-26 15:17:57 UTC

OK, this change to bump the default deploy wait to 10 minutes got into v1.0.22 of the plugin, which is in the recent brew-pulp jenkins images.

QE should be able to verify.

Comment 5 Xingxing Xia 2016-08-29 06:22:30 UTC

Verified in openshift3/jenkins-1-rhel7@sha256:4be90f13eb93 , now the time is set to 600000 (10 mins)

Comment 7 errata-xmlrpc 2016-09-27 09:10:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1937