Bug 1368423

Summary:	core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	core	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.2	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1367527	Environment:
Last Closed:	2016-08-24 10:21:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1367527
Bug Blocks:

Description Niels de Vos 2016-08-19 10:59:51 UTC

+++ This bug was initially created as a clone of Bug #1367527 +++

Description of problem:

gnu glibc (libc) in Fedora 26 (rawhide) has turned off "compat" for makedev(), major(), and minor(3) decls.

3.8.2 on F26 built with warnings, see: https://kojipkgs.fedoraproject.org//packages/glusterfs/3.8.2/1.fc26/data/logs/x86_64/build.log

More recent builds of other packages (namely nfs-ganesha) indicate that these warnings would now be errors, and, e.g. will be errors when 3.8.3 is released and built.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-08-16 18:17:01 CEST ---

REVIEW: http://review.gluster.org/15182 (core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Vijay Bellur on 2016-08-16 20:09:07 CEST ---

REVIEW: http://review.gluster.org/15182 (core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

--- Additional comment from Vijay Bellur on 2016-08-19 12:58:43 CEST ---

COMMIT: http://review.gluster.org/15182 committed in master by Niels de Vos (ndevos) 
------
commit c441a0ae5aca1f2977961afecb3236f90eb5b672
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Tue Aug 16 12:14:43 2016 -0400

    core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)
    
    gnu glibc (libc) in Fedora 26 (rawhide) has turned off "compat" for
    makedev(), major(), and minor(3) decls.
    
    3.8.2 on F26 built with warnings, see:
    https://kojipkgs.fedoraproject.org//packages/glusterfs/3.8.2/1.fc26/data/logs/x86_64/build.log
    
    More recent builds of other packages (namely nfs-ganesha) indicate
    that these warnings would now be errors, and, will be errors when
    3.8.3 is released and built.
    
    Change-Id: I3caa0d05f5de695818753e40e754da8b40d2011c
    BUG: 1367527
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/15182
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>

Comment 1 Vijay Bellur 2016-08-19 11:01:23 UTC

REVIEW: http://review.gluster.org/15203 (core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)) posted (#1) for review on release-3.8 by Niels de Vos (ndevos)

Comment 2 Vijay Bellur 2016-08-21 11:43:00 UTC

REVIEW: http://review.gluster.org/15203 (core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)) posted (#2) for review on release-3.8 by Niels de Vos (ndevos)

Comment 3 Worker Ant 2016-08-22 08:43:49 UTC

COMMIT: http://review.gluster.org/15203 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 791d706eee153b4d61073ab67e1f77d2558158c9
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Tue Aug 16 12:14:43 2016 -0400

    core: use <sys/sysmacros.h> for makedev(3), major(3), minor(3)
    
    gnu glibc (libc) in Fedora 26 (rawhide) has turned off "compat" for
    makedev(), major(), and minor(3) decls.
    
    3.8.2 on F26 built with warnings, see:
    https://kojipkgs.fedoraproject.org//packages/glusterfs/3.8.2/1.fc26/data/logs/x86_64/build.log
    
    More recent builds of other packages (namely nfs-ganesha) indicate
    that these warnings would now be errors, and, will be errors when
    3.8.3 is released and built.
    
    Cherry picked from commit c441a0ae5aca1f2977961afecb3236f90eb5b672:
    > Change-Id: I3caa0d05f5de695818753e40e754da8b40d2011c
    > BUG: 1367527
    > Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    > Reviewed-on: http://review.gluster.org/15182
    > Smoke: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > Reviewed-by: Niels de Vos <ndevos>
    
    Change-Id: I3caa0d05f5de695818753e40e754da8b40d2011c
    BUG: 1368423
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/15203
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 4 Niels de Vos 2016-08-24 10:21:38 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.3, please open a new bug report.

glusterfs-3.8.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/announce/2016-August/000059.html
[2] https://www.gluster.org/pipermail/gluster-users/