Bug 1368623 (python-hamcrest)

Summary:	Review Request: python-hamcrest - Hamcrest matchers for Python
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Štěpán Smetana <ssmetana>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ssmetana
Target Milestone:	---	Flags:	ssmetana: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-06 18:23:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Igor Gnatenko 2016-08-20 06:53:50 UTC

Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/ignatenkobrain/behave-enhanced/python-hamcrest.git/plain/python-hamcrest.spec?id=59dd36583cf2122f0e075b61578a32992c4a3407
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/ignatenkobrain/behave-enhanced/fedora-rawhide-x86_64/00442835-python-hamcrest/python-hamcrest-1.8.5-1.fc26.src.rpm
Description:
PyHamcrest is a framework for writing matcher objects, allowing you to
declaratively define "match" rules. There are a number of situations where
matchers are invaluable, such as UI validation, or data filtering, but it is
in the area of writing flexible tests that matchers are most commonly used.
Fedora Account System Username: ignatenkobrain

Comment 1 Štěpán Smetana 2016-08-29 13:01:51 UTC

Add %license to spec file

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 111 files have unknown license.
     Detailed output of licensecheck in /home/temp/1368623-python-
     hamcrest/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.5/site-
     packages/hamcrest/library/integration/__pycache__([a/N]:, pořádku,
     V), /usr/lib/python2.7/site-packages/hamcrest/core([a/N]:, pořádku,
     V), /usr/lib/python3.5/site-
     packages/hamcrest/library/object/__pycache__([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-
     packages/hamcrest/library/text/__pycache__([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-packages/hamcrest/library/object([a/N]:,
     pořádku, V), /usr/lib/python3.5/site-
     packages/hamcrest/library/collection([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-packages/hamcrest([a/N]:, pořádku, V),
     /usr/lib/python2.7/site-packages/hamcrest/core/core([a/N]:, pořádku,
     V), /usr/lib/python3.5/site-
     packages/hamcrest/core/core/__pycache__([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-
     packages/hamcrest/library/number/__pycache__([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-packages/hamcrest/core/core([a/N]:, pořádku,
     V), /usr/lib/python2.7/site-packages/hamcrest/library/text([a/N]:,
     pořádku, V), /usr/lib/python3.5/site-
     packages/hamcrest/core/__pycache__([a/N]:, pořádku, V),
     /usr/lib/python2.7/site-packages/PyHamcrest-1.8.5-py2.7.egg-
     info([a/N]:, pořádku, V), /usr/lib/python3.5/site-
     packages/hamcrest/library([a/N]:, pořádku, V), /usr/lib/python3.5
     /site-packages/hamcrest/library/text([a/N]:, pořádku, V),
     /usr/lib/python2.7/site-packages/hamcrest/library/number([a/N]:,
     pořádku, V), /usr/lib/python2.7/site-
     packages/hamcrest/library/collection([a/N]:, pořádku, V),
     /usr/lib/python2.7/site-packages/hamcrest([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-packages/hamcrest/library/__pycache__([a/N]:,
     pořádku, V), /usr/lib/python2.7/site-
     packages/hamcrest/library/integration([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-
     packages/hamcrest/library/collection/__pycache__([a/N]:, pořádku,
     V), /usr/lib/python3.5/site-
     packages/hamcrest/core/helpers/__pycache__([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-packages/hamcrest/library/number([a/N]:,
     pořádku, V), /usr/lib/python3.5/site-
     packages/hamcrest/core/helpers([a/N]:, pořádku, V),
     /usr/lib/python2.7/site-packages/hamcrest/core/helpers([a/N]:,
     pořádku, V), /usr/lib/python2.7/site-
     packages/hamcrest/library/object([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-packages/hamcrest/core([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-packages/hamcrest/__pycache__([a/N]:,
     pořádku, V), /usr/lib/python2.7/site-
     packages/hamcrest/library([a/N]:, pořádku, V), /usr/lib/python3.5
     /site-packages/hamcrest/library/integration([a/N]:, pořádku, V),
     /usr/lib/python3.5/site-packages/PyHamcrest-1.8.5-py3.5.egg-
     info([a/N]:, pořádku, V)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-hamcrest , python3-hamcrest
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: python2-hamcrest-1.8.5-1.fc24.noarch.rpm
          python3-hamcrest-1.8.5-1.fc24.noarch.rpm
          python-hamcrest-1.8.5-1.fc24.src.rpm
python2-hamcrest.noarch: W: spelling-error Summary(en_US) matchers -> marchers, matches, catchers
python2-hamcrest.noarch: W: spelling-error %description -l en_US matcher -> marcher, matches, catcher
python2-hamcrest.noarch: W: spelling-error %description -l en_US declaratively -> declarative, decoratively, relatively
python2-hamcrest.noarch: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers
python2-hamcrest.noarch: W: no-documentation
python3-hamcrest.noarch: W: spelling-error Summary(en_US) matchers -> marchers, matches, catchers
python3-hamcrest.noarch: W: spelling-error %description -l en_US matcher -> marcher, matches, catcher
python3-hamcrest.noarch: W: spelling-error %description -l en_US declaratively -> declarative, decoratively, relatively
python3-hamcrest.noarch: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers
python3-hamcrest.noarch: W: no-documentation
python-hamcrest.src: W: spelling-error Summary(en_US) matchers -> marchers, matches, catchers
python-hamcrest.src: W: spelling-error %description -l en_US matcher -> marcher, matches, catcher
python-hamcrest.src: W: spelling-error %description -l en_US declaratively -> declarative, decoratively, relatively
python-hamcrest.src: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers
3 packages and 0 specfiles checked; 0 errors, 14 warnings.




Rpmlint (installed packages)
----------------------------
python3-hamcrest.noarch: W: spelling-error Summary(en_US) matchers -> marchers, matches, catchers
python3-hamcrest.noarch: W: spelling-error %description -l en_US matcher -> marcher, matches, catcher
python3-hamcrest.noarch: W: spelling-error %description -l en_US declaratively -> declarative, decoratively, relatively
python3-hamcrest.noarch: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers
python3-hamcrest.noarch: W: no-documentation
python2-hamcrest.noarch: W: spelling-error Summary(en_US) matchers -> marchers, matches, catchers
python2-hamcrest.noarch: W: spelling-error %description -l en_US matcher -> marcher, matches, catcher
python2-hamcrest.noarch: W: spelling-error %description -l en_US declaratively -> declarative, decoratively, relatively
python2-hamcrest.noarch: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers
python2-hamcrest.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 10 warnings.



Diff spec file in url and in SRPM
---------------------------------
--- /home/temp/1368623-python-hamcrest/srpm/python-hamcrest.spec	2016-08-29 14:21:48.758841197 +0200
+++ /home/temp/1368623-python-hamcrest/srpm-unpacked/python-hamcrest.spec	2016-08-19 17:25:36.000000000 +0200
@@ -10,5 +10,5 @@
 Name:           python-%{modname}
 Version:        1.8.5
-Release:        2%{?dist}
+Release:        1%{?dist}
 Summary:        Hamcrest matchers for Python
 
@@ -17,11 +17,4 @@
 Source0:        %{url}/archive/V%{version}/%{name}-%{version}.tar.gz
 
-# https://github.com/hamcrest/PyHamcrest/commit/4327d0be0ca6adfaec427b96149219a224dc826c
-Patch0001:      0001-correct-calling-API-call-with-args.patch
-# https://github.com/hamcrest/PyHamcrest/commit/27fd600fb24aacef589feddb06ef1725ca30319b
-Patch0002:      0001-Return-result-of-a-deferred-call.patch
-# https://github.com/hamcrest/PyHamcrest/commit/37a4d0dbeb9a92b959edfb9b1aceba4eaacf9f78
-Patch0003:      0001-Add-boolean-matchers.patch
-
 BuildArch:      noarch
 
@@ -72,5 +65,5 @@
 
 %prep
-%autosetup -n %{origname}-%{version} -p1
+%autosetup -n %{origname}-%{version}
 
 %build
@@ -105,7 +98,4 @@
 
 %changelog
-* Sun Aug 21 2016 Igor Gnatenko <ignatenko> - 1.8.5-2
-- Backport couple of upstream patches
-
 * Fri Aug 19 2016 Igor Gnatenko <ignatenko> - 1.8.5-1
 - Initial package


Requires
--------
python3-hamcrest (rpmlib, GLIBC filtered):
    python(abi)
    python3-six

python2-hamcrest (rpmlib, GLIBC filtered):
    python(abi)
    python2-six



Provides
--------
python3-hamcrest:
    python3-hamcrest

python2-hamcrest:
    python-hamcrest
    python2-hamcrest



Source checksums
----------------
https://github.com/hamcrest/PyHamcrest/archive/V1.8.5/python-hamcrest-1.8.5.tar.gz :
  CHECKSUM(SHA256) this package     : a0470f63437f7a4b1ef442144af688c7216a92611de981daf055c41f49a09d5f
  CHECKSUM(SHA256) upstream package : a0470f63437f7a4b1ef442144af688c7216a92611de981daf055c41f49a09d5f


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1368623
Buildroot used: fedora-24-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 2 Gwyn Ciesla 2016-09-01 12:10:48 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-hamcrest

Comment 3 Fedora Update System 2016-09-01 13:10:50 UTC

python-hamcrest-1.8.5-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-81dbf2c17c

Comment 4 Fedora Update System 2016-09-01 13:10:59 UTC

python-hamcrest-1.8.5-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-43e15308ee

Comment 5 Fedora Update System 2016-09-03 03:24:34 UTC

python-hamcrest-1.8.5-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-43e15308ee

Comment 6 Fedora Update System 2016-09-03 03:55:10 UTC

python-hamcrest-1.8.5-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-81dbf2c17c

Comment 7 Fedora Update System 2016-09-06 18:23:02 UTC

python-hamcrest-1.8.5-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2016-09-23 16:20:03 UTC

python-hamcrest-1.8.5-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.