Bug 1368868

Summary:	recipe.files() returns duplicate logs
Product:	[Retired] Beaker	Reporter:	matt jia <mjia>
Component:	lab controller	Assignee:	beaker-dev-list
Status:	CLOSED DUPLICATE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	23	CC:	dcallagh, mjia, rjoost
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-23 02:24:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description matt jia 2016-08-22 01:11:23 UTC

Description of problem:

The recipe.files() returns duplicate logs which causes 

OSError: [Errno 17] File exists

in beaker-transfer daemon.
 
Version-Release number of selected component (if applicable):

23

How reproducible:

Easy

Steps to Reproduce:

check the logs for 483436#task5612659 on the production site

Actual results:

It has two debug/.task_beah_raw records when clicking on the logs icon

Expected results:

Only one record should be shown.

Additional info:

See bug 1368509 for what happened in beaker-transfer.

Comment 1 matt jia 2016-08-22 03:23:15 UTC

(In reply to matt jia from comment #0)
> Description of problem:
> 
> The recipe.files() returns duplicate logs which causes 
> 
> OSError: [Errno 17] File exists
> 

It turns out this task(483436) has reported two results with same filename.

select recipe_task_id, filename from Beaker.log_recipe_task where recipe_task_id = 5612659 ;
 recipe_task_id |       filename       
----------------+----------------------
        5612659 | .task_beah_raw
        5612659 | .task_beah_raw
        5612659 | journal.xml
        5612659 | TESTOUT.log
        5612659 | task_beah_unexpected
        5612659 | messages
        5612659 | current.log
        5612659 | task_output_stdout
        5612659 | task_log
(9 rows)

Should we allow this? It does not make senses to me that one task have two logs with same name.

Comment 2 Dan Callaghan 2016-08-23 02:24:50 UTC

It should be impossible. We currently cannot explain how it is happening. We've seen it twice before.

*** This bug has been marked as a duplicate of bug 963492 ***