Bug 1368869

Summary: Should give more clear message for multiple update on BC & DC Environment tab
Product: OKD Reporter: Yadan Pei <yapei>
Component: Management ConsoleAssignee: Samuel Padgett <spadgett>
Status: CLOSED CURRENTRELEASE QA Contact: XiaochuanWang <xiaocwan>
Severity: low Docs Contact:
Priority: low    
Version: 3.xCC: aos-bugs, jforrest, jvallejo, mmccomas, rhamilto, spadgett, wsun, xiaocwan, yapei
Target Milestone: ---   
Target Release: 3.x   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-09-26 12:58:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
FlickerWhenSaving none

Description Yadan Pei 2016-08-22 01:25:44 UTC 
Description of problem:
On DC Environment tab & BC Environment tab, after making sequential changes to env name/value, only one alert "<bc> was updated." is given, this is not very clear. 

Version-Release number of selected component (if applicable):
openshift v1.3.0-alpha.3+7b3e38d
kubernetes v1.3.0+507d3a7
etcd 2.3.0+git


How reproducible:
Always

Steps to Reproduce:
1.Create app from image
2.Go to BC/DC Environment tab
3.Add one pair of name/value
4.Add another pair of name/value

Actual results:
4. Only one alert is given, it's hard to identify the new changes

Expected results:
4. Should give more clear message for sequential updates

Additional info:
Comment 1 Jessica Forrester 2016-12-02 17:41:09 UTC 
*** Bug 1400889 has been marked as a duplicate of this bug. ***
Comment 2 Juan Vallejo 2016-12-02 22:17:32 UTC 
Related PR: https://github.com/openshift/origin-web-console/pull/981
Comment 3 Jessica Forrester 2017-07-07 17:21:35 UTC 
Will be getting fixed as part of some toast notification changes. https://github.com/openshift/origin-web-console/pull/1804
Comment 4 Samuel Padgett 2017-07-20 12:47:01 UTC 
All of the env editors should now use toast notifications, which have a separate alert for each save.
Comment 5 XiaochuanWang 2017-07-24 08:03:27 UTC 
Adding or updating any key/value for env is using toast notifications now, verified on:
OpenShift Master:      v3.6.153
Kubernetes Master:     v1.6.1+5115d708d7
Comment 7 Yadan Pei 2017-07-26 05:52:39 UTC 
Should I set target release as 3.7?
Comment 9 Yadan Pei 2017-07-27 09:18:58 UTC 
Checked on
OpenShift Master: v3.6.0-rc.0+fb2b87a-291
Kubernetes Master: v1.7.0+695f48a16f 

Now there are separate notification for each update, this is working as expected.

But flicker still shows up on each save for both BC & DC environment changes.

Assign this back
Comment 10 Samuel Padgett 2017-07-28 20:01:59 UTC 
How severe is the flicker? Is it a new problem? Can you make a movie or animated gif?

The flicker should probably be a separate bug since the original problem is fixed.
Comment 11 Yadan Pei 2017-07-31 08:43:40 UTC 
Created attachment 1306888 [details]
FlickerWhenSaving
Comment 12 Yadan Pei 2017-07-31 08:45:35 UTC 
Please check my newly uploaded record and determine if it's an issue. It's not a big problem but I do agree to draft a separate bug for this.
Comment 13 Yadan Pei 2017-07-31 08:46:18 UTC 
Sam, I will draft a new bug if you determine it's a problem
Comment 14 Samuel Padgett 2017-07-31 12:55:06 UTC 
Yeah, I think we need a bug to track this. Do you mind opening a new one?

Moving back to ON_QA for the original problem.
Comment 15 Samuel Padgett 2017-07-31 13:30:10 UTC 
What OS and version of Firefox are you seeing the flicking with?
Comment 16 Yadan Pei 2017-08-01 05:51:49 UTC 
Move to VERIFIED since toast notification was used, there is message for each update
Comment 17 Yadan Pei 2017-08-16 01:04:47 UTC 
Firefox 25 & Firefox 54, I will try and draft a new bug if reproduced