Bug 1368913

Summary:	Openshift master major version info messed up
Product:	OpenShift Container Platform	Reporter:	Xia Zhao <xiazhao>
Component:	oc	Assignee:	Clayton Coleman <ccoleman>
Status:	CLOSED ERRATA	QA Contact:	Xingxing Xia <xxia>
Severity:	low	Docs Contact:
Priority:	medium
Version:	3.3.0	CC:	aos-bugs, jokerman, mmccomas, tdawson
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-27 09:45:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xia Zhao 2016-08-22 05:37:34 UTC

Description of problem:
Install OSE latest puddle (v3.3.0.23), after it completes successfully, got extra string "dirty" in command "openshift version":
# openshift version
openshift v3.3.0.23-dirty
kubernetes v1.3.0+507d3a7
etcd 2.3.0+git

Version-Release number of selected component (if applicable):
openshift v3.3.0.23-dirty
kubernetes v1.3.0+507d3a7
etcd 2.3.0+git

How reproducible:
Always

Steps to Reproduce:
1.Install OSE with the latest puddle (v3.3.0.23)

Actual results:
# openshift version
openshift v3.3.0.23-dirty
kubernetes v1.3.0+507d3a7
etcd 2.3.0+git

Expected results:
# openshift version
openshift v3.3.0.23
kubernetes v1.3.0+507d3a7
etcd 2.3.0+git

Additional info:
1. Repro on both openstack and AWS
2. Not repro with last puddle v3.3.0.22

Comment 1 Juan Vallejo 2016-08-23 20:32:09 UTC

Closing this as not a bug. See conversation in this thread:
https://github.com/openshift/origin/pull/10602#issuecomment-241857909

Comment 2 Juan Vallejo 2016-08-23 20:35:47 UTC

> Closing this as not a bug. See conversation in this thread:
> https://github.com/openshift/origin/pull/10602#issuecomment-241857909

The reason why "dirty" shows up in version information is because the openshift build is leaving the working directory in a dirty state.

Re-assigning to mkargaki to get his thoughts on this before closing.

https://github.com/openshift/origin/pull/10602#issuecomment-241857909

Comment 3 Michail Kargakis 2016-08-24 08:42:43 UTC

https://github.com/openshift/origin/pull/10602#issuecomment-241858026 should be addressed. I am not sure who is responsible for the build process of the repo. Probably Clayton?

Comment 4 Troy Dawson 2016-09-01 15:38:36 UTC

This was an OSE bug, not openshift origin.  It has been fixed in OSE v3.3.0.28 or newer.
We have also pushed the fix upstream in this pull request.
https://github.com/openshift/origin/pull/10666

But marking this onto QE so that the OSE issue can be verified and closed.

Comment 8 errata-xmlrpc 2016-09-27 09:45:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1933