Bug 1369457

Summary: File permission changes inside hibernate JARs
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Fernando Nasser <fnasser>
Component: BuildAssignee: jboss-set
Status: CLOSED EOL QA Contact: Pavel Slavicek <pslavice>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.4.10CC: psakar, vtunka
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-19 12:46:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Fernando Nasser 2016-08-23 13:05:00 UTC
The rpmdiff tool that is used to check RPMs is giving us failures as it detected changes in the permissions of files inside .jar files.

We've tracked this down to changes in the Maven builds done for 6.4.10. 

This is due to changes in the Maven builds for Hibernate 4.2.23 and 4.2.24.:

VERIFY 	  	hibernate4-c3p0-eap6 > usr/share/java/hibernate4-eap6/hibernate-c3p0-4.2.2{3|4}.Final-redhat-1.jar 	  	File /org changed permissions from 0775 to 0755 on noarch
VERIFY 	  	hibernate4-c3p0-eap6 > usr/share/java/hibernate4-eap6/hibernate-c3p0-4.2.2{3|4}.Final-redhat-1.jar 	  	File /org/hibernate changed permissions from 0775 to 0755 on noarch
VERIFY 	  	hibernate4-c3p0-eap6 > usr/share/java/hibernate4-eap6/hibernate-c3p0-4.2.2{3|4}.Final-redhat-1.jar 	  	File /org/hibernate/service changed permissions from 0775 to 0755 on noarch
VERIFY 	  	hibernate4-c3p0-eap6 > usr/share/java/hibernate4-eap6/hibernate-c3p0-4.2.2{3|4}.Final-redhat-1.jar 	  	File /org/hibernate/service/jdbc changed permissions from 0775 to 0755 on noarch
VERIFY 	  	hibernate4-c3p0-eap6 > usr/share/java/hibernate4-eap6/hibernate-c3p0-4.2.2{3|4}.Final-redhat-1.jar 	  	File /org/hibernate/service/jdbc/connections changed permissions from 0775 to 0755 on noarch
VERIFY 	  	hibernate4-c3p0-eap6 > usr/share/java/hibernate4-eap6/hibernate-c3p0-4.2.2{3|4}.Final-redhat-1.jar 	  	File /org/hibernate/service/jdbc/connections/internal changed permissions from 0775 to 0755 on noarch
VERIFY 	  	hibernate4-c3p0-eap6 > usr/share/java/hibernate4-eap6/hibernate-c3p0-4.2.2{3|4}.Final-redhat-1.jar 	  	File /org/hibernate/service/jdbc/connections/internal/C3P0ConnectionProvider.class changed permissions from 0664 to 0644 on noarch

More than 350 messages were reported by this test; a further 3992 messages would have been reported but are being suppressed to keep the web UI and email notifications usable.


Similar happened to the -source.jar


VERIFY 	  	hibernate4-core-eap6 > usr/share/java/hibernate4-eap6/hibernate-core-4.2.2{3|4}.Final-redhat-1-sources.jar 	  	File /org/hibernate/CacheMode.java changed permissions from 0755 to 0644 on noarch
VERIFY 	  	hibernate4-core-eap6 > usr/share/java/hibernate4-eap6/hibernate-core-4.2.2{3|4}.Final-redhat-1-sources.jar 	  	File /org/hibernate/EmptyInterceptor.java changed permissions from 0755 to 0644 on noarch
VERIFY 	  	hibernate4-core-eap6 > usr/share/java/hibernate4-eap6/hibernate-core-4.2.2{3|4}.Final-redhat-1-sources.jar 	  	File /org/hibernate/SQLQuery.java changed permissions from 0755 to 0644 on noarch
VERIFY 	  	hibernate4-core-eap6 > usr/share/java/hibernate4-eap6/hibernate-core-4.2.2{3|4}.Final-redhat-1-sources.jar 	  	File /org/hibernate/ScrollMode.java changed permissions from 0755 to 0644 on noarch
VERIFY 	  	hibernate4-core-eap6 > usr/share/java/hibernate4-eap6/hibernate-core-4.2.2{3|4}.Final-redhat-1-sources.jar 	  	File /org/hibernate/SessionException.java changed permissions from 0755 to 0644 on noarch
VERIFY 	  	hibernate4-core-eap6 > usr/share/java/hibernate4-eap6/hibernate-core-4.2.2{3|4}.Final-redhat-1-sources.jar 	  	File /org/hibernate/StaleStateException.java changed permissions from 0755 to 0644 on noarch

More than 350 messages were reported by this test; a further 3992 messages would have been reported but are being suppressed to keep the web UI and email notifications usable.

Comment 1 Fernando Nasser 2016-08-23 13:08:05 UTC
On 2016-08-22 4:42 PM, Tomaz Cerar wrote:
>
> On Mon, Aug 22, 2016 at 10:32 PM, Fernando Nasser <fnasser> wrote:
>
>     I was going to say we dismiss this as not important, but then I saw that the new Hibernate JARs have also been affected, but in bulk:
>
>
>
> Given that hibernate is build by gradle not maven, cause may be somewhere else.

It is a good point Tomaz, but in MEAD it is wrapped in Maven.  It uses some maven-gradle-plugin and I am not sure who end up being responsible for creating the .jar files at the end.

Comment 2 Fernando Nasser 2016-08-23 13:10:34 UTC
On 2016-08-23 2:58 AM, Lin Gao wrote:
> Just a guess:
>
>  Is it possible the 'umask' related thing, build comes from differnt host with different 'umask' setting may produce different permission files.

Comment 3 Petr Sakaƙ 2016-08-23 14:32:17 UTC
see https://bugzilla.redhat.com/show_bug.cgi?id=1369449#c2