Bug 1369464
| Summary: | Review Request: rubygem-proxifier - Proxifier is a gem to force ruby to use a proxy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanis Guenane <yguenane> |
| Component: | Package Review | Assignee: | Matthias Runge <mrunge> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mrunge, package-review, sbonazzo |
| Target Milestone: | --- | Flags: | mrunge:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-12-06 19:01:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Yanis Guenane
2016-08-23 13:25:30 UTC
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package contains Requires: ruby(release).
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 13 files have
unknown license. Detailed output of licensecheck in
/home/fedora/1369464-rubygem-proxifier/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gems,
/usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[ ]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
===== SHOULD items =====
Generic:
[x]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
proxifier-doc
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
Ruby:
[!]: Gem should use %gem_install macro.
[x]: Gem package should exclude cached Gem.
[x]: gems should not require rubygems package
[x]: Specfile should use macros from rubygem-devel package.
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: rubygem-proxifier-1.0.3-1.fc24.noarch.rpm
rubygem-proxifier-doc-1.0.3-1.fc24.noarch.rpm
rubygem-proxifier-1.0.3-1.fc24.src.rpm
rubygem-proxifier.noarch: W: no-documentation
rubygem-proxifier.noarch: E: wrong-script-interpreter /usr/share/gems/gems/proxifier-1.0.3/bin/pruby /usr/bin/env ruby
rubygem-proxifier.noarch: E: wrong-script-interpreter /usr/share/gems/gems/proxifier-1.0.3/bin/pirb /usr/bin/env ruby
rubygem-proxifier.noarch: W: no-manual-page-for-binary pirb
rubygem-proxifier.noarch: W: no-manual-page-for-binary pruby
3 packages and 0 specfiles checked; 2 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
rubygem-proxifier.noarch: W: no-documentation
rubygem-proxifier.noarch: E: wrong-script-interpreter /usr/share/gems/gems/proxifier-1.0.3/bin/pruby /usr/bin/env ruby
rubygem-proxifier.noarch: E: wrong-script-interpreter /usr/share/gems/gems/proxifier-1.0.3/bin/pirb /usr/bin/env ruby
rubygem-proxifier.noarch: W: no-manual-page-for-binary pirb
rubygem-proxifier.noarch: W: no-manual-page-for-binary pruby
2 packages and 0 specfiles checked; 2 errors, 3 warnings.
Diff spec file in url and in SRPM
---------------------------------
--- /home/fedora/1369464-rubygem-proxifier/srpm/rubygem-proxifier.spec 2016-08-24 07:18:24.227574680 +0000
+++ /home/fedora/1369464-rubygem-proxifier/srpm-unpacked/rubygem-proxifier.spec 2016-08-18 07:16:12.000000000 +0000
@@ -1,3 +1,3 @@
-# Generated from proxifier-1.0.3.gem by gem2rpm -*- rpm-spec -*-
+# Generated from proxifier-1.0.3.gem by gem2rpm -*- rpm-spec -*-
%global gem_name proxifier
@@ -78,3 +78,3 @@
%changelog
* Wed Aug 17 2016 Yanis Guenane <yguenane> - 1.0.3-1
-- Initial package
\ No newline at end of file
+- Initial package
Requires
--------
rubygem-proxifier-doc (rpmlib, GLIBC filtered):
rubygem-proxifier
rubygem-proxifier (rpmlib, GLIBC filtered):
/usr/bin/env
/usr/bin/ruby
ruby(rubygems)
Provides
--------
rubygem-proxifier-doc:
rubygem-proxifier-doc
rubygem-proxifier:
rubygem(proxifier)
rubygem-proxifier
Source checksums
----------------
https://rubygems.org/gems/proxifier-1.0.3.gem :
CHECKSUM(SHA256) this package : 40fef4d2c79313a12b8be2799146cb225b35665975a238ba0d513a96c6a37fa9
CHECKSUM(SHA256) upstream package : 40fef4d2c79313a12b8be2799146cb225b35665975a238ba0d513a96c6a37fa9
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1369464
Buildroot used: fedora-24-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Issues:
- make sure, spec file form the srpm and actual spec file matches
- use /usr/bin/ruby instead of /usr/bin/env ruby
- use %gem_install macro
Please fix the issues.
SPEC URL: https://gist.githubusercontent.com/Spredzy/68b293763e5e0b7c1cd6fef0769d51cf/raw/67cf8953770193bd9187f3722d289d900ab08cd9/rubygem-proxifier.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/5796/15425796/rubygem-proxifier-1.0.3-1.fc24.src.rpm Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package contains Requires: ruby(release).
===== MUST items =====
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gems,
/usr/share/gems/doc
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[ ]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
===== SHOULD items =====
Generic:
[ ]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
proxifier-doc
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
Ruby:
[x]: Gem package should exclude cached Gem.
[x]: Gem should use %gem_install macro.
[x]: gems should not require rubygems package
[x]: Specfile should use macros from rubygem-devel package.
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: rubygem-proxifier-1.0.3-1.fc23.noarch.rpm
rubygem-proxifier-doc-1.0.3-1.fc23.noarch.rpm
rubygem-proxifier-1.0.3-1.fc23.src.rpm
rubygem-proxifier.noarch: W: no-documentation
rubygem-proxifier.noarch: W: no-manual-page-for-binary pirb
rubygem-proxifier.noarch: W: no-manual-page-for-binary pruby
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
rubygem-proxifier.noarch: W: no-documentation
rubygem-proxifier.noarch: W: no-manual-page-for-binary pirb
rubygem-proxifier.noarch: W: no-manual-page-for-binary pruby
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Requires
--------
rubygem-proxifier-doc (rpmlib, GLIBC filtered):
rubygem-proxifier
rubygem-proxifier (rpmlib, GLIBC filtered):
/usr/bin/ruby
ruby(rubygems)
Provides
--------
rubygem-proxifier-doc:
rubygem-proxifier-doc
rubygem-proxifier:
rubygem(proxifier)
rubygem-proxifier
Source checksums
----------------
https://rubygems.org/gems/proxifier-1.0.3.gem :
CHECKSUM(SHA256) this package : 40fef4d2c79313a12b8be2799146cb225b35665975a238ba0d513a96c6a37fa9
CHECKSUM(SHA256) upstream package : 40fef4d2c79313a12b8be2799146cb225b35665975a238ba0d513a96c6a37fa9
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1369464
Buildroot used: fedora-23-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
I checked the updated package again, and now I couldn't find any issues. Package APPROVED Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-proxifier |