Bug 1369523

Summary:	worm: variable reten_mode is invalid to be free by mem_put in fini()
Product:	[Community] GlusterFS	Reporter:	Ryan Ding <ryan.ding>
Component:	core	Assignee:	Ryan Ding <ryan.ding>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.10.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-06 17:23:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ryan Ding 2016-08-23 16:07:15 UTC

Description of problem:

priv->reten_mode is initialised by option 'retention-mode'. and it reference the memory in this->options. so fini() use mem_put to free priv->reten_mode will cause a problem.

Comment 1 Worker Ant 2016-08-23 16:14:06 UTC

REVIEW: http://review.gluster.org/15296 (features/read-only: reten_mode is invalid to be free by mem_put()) posted (#1) for review on master by Anonymous Coward

Comment 2 Worker Ant 2016-10-18 14:13:12 UTC

COMMIT: http://review.gluster.org/15296 committed in master by Jeff Darcy (jdarcy) 
------
commit 975c5572a8300c81e127c27e677974f49e96bd5d
Author: Ryan Ding <ryan.ding>
Date:   Wed Aug 24 00:08:12 2016 +0800

    features/read-only: reten_mode is invalid to be free by mem_put()
    
    priv->reten_mode is initialised by option 'retention-mode'. and it
    reference the memory in this->options. so fini() use mem_put to free
    priv->reten_mode will cause a problem.
    there is no need to call mem_put(), so just remove it will be fine.
    
    Change-Id: Iee6f9d1d54df38cba8c9b9100e2824f4f2b18ab4
    BUG: 1369523
    Signed-off-by: Ryan Ding <ryan.ding>
    Reviewed-on: http://review.gluster.org/15296
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>

Comment 3 Shyamsundar 2017-03-06 17:23:44 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/