Bug 1369590

Summary: Undefined element in bootstrap/less/navbar.less causes less compilation error with less 2.7
Product: [Retired] Beaker Reporter: Jon Orris <jorris>
Component: web UIAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: Roman Joost <rjoost>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: dcallagh, mjia, rjoost
Target Milestone: 25.5Keywords: Patch, Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-07-23 06:40:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jon Orris 2016-08-23 21:06:03 UTC
Description of problem:

 FilterError: less: subprocess returned a non-success result code: 1, stdout=, stderr=NameError: #grid > .core > .span is undefined in bootstrap/less/navbar.less on line 199, column 3:
 199   #grid > .core > .span(@gridColumns);

Error found both in newly installed beaker-server rpm and in source checkout.

Workaround: Comment out line in navbar.less

Comment 1 Dan Callaghan 2016-08-23 22:52:45 UTC
What version of the python-webassets and nodejs-less packages?

I think if this were failing in any of our (RHEL6-based) environments we would notice immediately because it would leave the whole web UI with no CSS. So I'm guessing this is on a recent Fedora release with a newer version of LESS that has some changes/regressions, or something like that?

Comment 2 Jon Orris 2016-08-23 23:17:13 UTC
(In reply to Dan Callaghan from comment #1)
> What version of the python-webassets and nodejs-less packages?
> 
> I think if this were failing in any of our (RHEL6-based) environments we
> would notice immediately because it would leave the whole web UI with no
> CSS. So I'm guessing this is on a recent Fedora release with a newer version
> of LESS that has some changes/regressions, or something like that?

nodejs-less-2.7.1-1 and python2-webassets-0.11.1-2

Yeah, I'm running this on Fedora 24, so not clear if it's a legitimate issue that less-2.7 is more picky about, or a bug/incompatability in less

Comment 3 Roman Joost 2016-09-13 00:10:04 UTC
I'm closing this bug at the moment, since I think we'll be running into this right when we upgrade to a newer platform. Thanks for reporting!

Comment 4 Dan Callaghan 2018-07-06 04:49:17 UTC
Not sure why this was closed, we need to fix it at some point if we ever want Beaker to work on recent Fedora releases. (Dogfood on Fedora 28 fails with this error currently.)

Comment 5 Dan Callaghan 2018-07-06 05:19:56 UTC
https://gerrit.beaker-project.org/#/c/beaker/+/6190

Comment 6 Roman Joost 2018-07-23 02:31:55 UTC
This can be tested with a beaker-server RPM version 25.5.git.22.27c58f217

Comment 7 Roman Joost 2018-07-23 03:46:38 UTC
I tested this on my local workstation with Fedora 28 installed. I installed beaker-server-25.4-1.fc28.noarch to check if I can reproduce the error:

[Mon Jul 23 13:39:13.108433 2018] [wsgi:error] [pid 30075:tid 140527512536832] [remote ::1:42504] FilterError: less: subprocess returned a non-success result code: 1, stdout=, stderr=\x1b[31mNameError: #grid > .core > .span is undefined\x1b[39m\x1b[31m in \x1b[39mbootstrap/less/navbar.less\x1b[90m on line 199, column 3:\x1b[39m

Then I installed: beaker-server.noarch 25.5-0.git.24.ffc6bc62f.fc28 and the error is gone.

Comment 8 Roman Joost 2018-07-23 06:40:50 UTC
Released with Beaker 25.5: https://beaker-project.org/docs/whats-new/release-25.html#beaker-25-5