Bug 1369598

Created attachment 1193435 [details]
patch

Description of problem:

When the linux guest has bonding kernel module enabled, then vagrant up fails with the following error.


ERROR STARTS++++++++++++++++++++++++++++++++++++++++++++++++++++

The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

cat /sys/class/net/bonding_masters/address

Stdout from the command:



Stderr from the command:

cat: /sys/class/net/bonding_masters/address: Not a directory


ERROR ENDS++++++++++++++++++++++++++++++++++++++++++++++++++++


CAUSE
==============================================================

When bonding is enabled, we have a file in /sys/class/net by name bonding_masters.

here is a sample output of /sys/class/net

[root@server1 vagrant]# ls -l /sys/class/net/
total 0
lrwxrwxrwx. 1 root root    0 Aug 23 21:10 bond0 -> ../../devices/virtual/net/bond0
-rw-r--r--. 1 root root 4096 Aug 23 21:10 bonding_masters
lrwxrwxrwx. 1 root root    0 Aug 23 21:10 eth0 -> ../../devices/pci0000:00/0000:00:07.0/virtio4/net/eth0
lrwxrwxrwx. 1 root root    0 Aug 23 21:10 eth1 -> ../../devices/pci0000:00/0000:00:08.0/virtio5/net/eth1
lrwxrwxrwx. 1 root root    0 Aug 23 21:10 eth2 -> ../../devices/pci0000:00/0000:00:09.0/virtio6/net/eth2
lrwxrwxrwx. 1 root root    0 Aug 23 21:10 lo -> ../../devices/virtual/net/lo



In vagrant 1.8.1, the interfaces are determined in 
/usr/share/vagrant/plugins/guests/fedora/cap/configure_networks.rb
by the command

machine.communicate.sudo("ls /sys/class/net | egrep -v lo\\|docker")
and 
machine.communicate.sudo("cat /sys/class/net/#{ifname}/address")

and cat /sys/class/net/bonding_masters/address fails as bonding_masters is not a dir.


FIX
==================================================================
A clean but large fix has gone in 1.8.5 in patch 
https://github.com/mitchellh/vagrant/commit/8f3b6511f280cd6211d83dd46c9558623fe0d1f7


I would recommend that we take the upstream fix. However, if that is not possible then at least a temp fix should be provided. I have attached a patch with temp fix that I have tested.





Version-Release number of selected component (if applicable):
vagrant-1.8.1-3.fc24.noarch


How reproducible:
always