Bug 1369807

Summary: NGN fails to install
Product: [oVirt] ovirt-node Reporter: Simone Tiraboschi <stirabos>
Component: Installation & UpdateAssignee: Ryan Barry <rbarry>
Status: CLOSED NEXTRELEASE QA Contact: cshao <cshao>
Severity: urgent Docs Contact:
Priority: high    
Version: 4.0CC: bugs, fdeutsch, rbarry, sbonazzo
Target Milestone: ovirt-4.0.3Keywords: Regression, TestBlocker
Target Release: 4.0Flags: sbonazzo: ovirt-4.0.z?
sbonazzo: blocker?
rule-engine: planning_ack?
fdeutsch: devel_ack+
rule-engine: testing_ack?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-25 07:22:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1369099    

Description Simone Tiraboschi 2016-08-24 12:57:30 UTC
Description of problem:
NGN fails to install

It reports:
There was an error running the kickstart script at line 7.  This is a fatal error and installation will be aborted.  The details of this error are:
 
[INFO] Trying to create a manageable base from '/'
[INFO] Initial base will be <Base ovirt-node-ng-4.0.2-0.20160821.0 [] />
[INFO] Initial layer will be <Layer ovirt-node-ng-4.0.2-0.20160821.0+1 />
[INFO] Creating an initial base <Base ovirt-node-ng-4.0.2-0.20160821.0 [] /> for <LV 'onn_ngnt1/root' />
  WARNING: Sum of all thin volume sizes (68.16 GiB) exceeds the size of thin pool onn_ngnt1/pool00 and the size of whole volume group (54.51 GiB)!
[INFO] Creating initial layer <Layer ovirt-node-ng-4.0.2-0.20160821.0+1 /> for initial base
[INFO] Adding a new layer after <Base ovirt-node-ng-4.0.2-0.20160821.0 [] />
[INFO] Adding a new layer after <Base ovirt-node-ng-4.0.2-0.20160821.0 [] />
[INFO] New layer will be: <Layer ovirt-node-ng-4.0.2-0.20160821.0+1 />
  WARNING: Sum of all thin volume sizes (95.55 GiB) exceeds the size of thin pool onn_ngnt1/pool00 and the size of whole volume group (54.51 GiB)!
[INFO] Verifying stream compatability
[INFO] Migrating /etc (from <LV 'onn_ngnt1/ovirt-node-ng-4.0.2-0.20160821.0+1' />)
[INFO] Migrating /root
[INFO] Inspecting if the layer contains OS data
[INFO] Adjusting mount and boot related points
[INFO] Updating fstab of new layer
[ERROR] Failed to update OS
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 76, in on_new_layer
    adjust_mounts_and_boot(imgbase, new_lv, previous_layer_lv)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 403, in adjust_mounts_and_boot
    update_fstab(newroot.target)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 251, in update_fstab
    e = newfstab.by_target(tgt)
  File "/usr/lib/python2.7/site-packages/imgbased/utils.py", line 594, in by_target
    return targets[target]
KeyError: '/var'
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/site-packages/imgbased/__main__.py", line 51, in <module>
    CliApplication()
  File "/usr/lib/python2.7/site-packages/imgbased/__init__.py", line 82, in CliApplication
    app.hooks.emit("post-arg-parse", args)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/core.py", line 162, in post_argparse
    layout.initialize(args.source, args.init_nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/core.py", line 210, in initialize
    self.app.imgbase.init_layout_from(source, init_nvr)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 244, in init_layout_from
    self.add_layer(initial_base, new_layer)
  File "/usr/lib/python2.7/site-packages/imgbased/imgbase.py", line 170, in add_layer
    self.hooks.emit("new-layer-added", prev_lv, new_lv)
  File "/usr/lib/python2.7/site-packages/imgbased/hooks.py", line 120, in emit
    cb(self.context, *args)
  File "/usr/lib/python2.7/site-packages/imgbased/plugins/osupdater.py", line 80, in on_new_layer
    raise BootSetupError()
imgbased.plugins.osupdater.BootSetupError

Version-Release number of selected component (if applicable):
http://resources.ovirt.org/pub/ovirt-4.0/iso/ovirt-node-ng-installer/ovirt-node-ng-installer-ovirt-4.0-2016062412.iso (the released one)

ovirt-node-ng-installer-ovirt-4.0-2016082104.iso from jenkins

How reproducible:
4 on 4

Steps to Reproduce:
1. try to install with anaconda
2. single disk, auto partitioning
3.

Actual results:
it fails with:
[ERROR] Failed to update OS

Expected results:
it installs

Additional info:

Comment 2 Fabian Deutsch 2016-08-24 13:51:13 UTC
This bug does not affect RHVH

Comment 3 Ryan Barry 2016-08-24 14:29:46 UTC
The anaconda installclass was not being triggered, since updates.img was improperly generated.

This is fixed in:

http://jenkins.ovirt.org/job/ovirt-node-ng_ovirt-4.0_build-artifacts-el7-x86_64/42/artifact/exported-artifacts/

Comment 4 Fabian Deutsch 2016-08-25 07:22:05 UTC
What was the reason for the failure?

Comment 5 Ryan Barry 2016-08-25 12:11:18 UTC
anaconda's scripts/makeupdates was directly looking for a version after AC_INIT( in configure.ac. Using an additional -release (and initializing AC_INIT with variables) caused the version to be VERSION_RELEASE (instead of some version: i.e. '1.2.3.4'), and makeupdates git diff couldn't find the tag.

The current patch fixes makeupdates (which broke about a month ago when downstream was synced with github again), but is not a long-term solution for whenever we need to pick up a new version of anaconda.

We should push on the inclusion of the installclass again...