Bug 1369840

Summary: different types returned as the Percent property of Job objects
Product: [Community] LVM and device-mapper Reporter: Vratislav Podzimek <vpodzime>
Component: lvm2Assignee: LVM and device-mapper development team <lvm-team>
lvm2 sub component: lvmdbusd QA Contact: cluster-qe <cluster-qe>
Status: CLOSED UPSTREAM Docs Contact:
Severity: unspecified    
Priority: unspecified CC: agk, heinzm, jbrassow, msnitzer, prajnoha, tasleson, zkabelac
Version: 2.02.164Flags: rule-engine: lvm-technical-solution?
rule-engine: lvm-test-coverage?
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-12 13:46:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Comment 2 Tony Asleson 2016-08-25 03:36:45 UTC
The introspection actually is showing a 'y' == byte.  Unfortunately the python dbus library is picking the most appropriate type based on the value.  In some cases the value is faked because we don't have something returned from lvm and in other cases it's the actual value.

I will change it to always return a double.

Comment 3 Vratislav Podzimek 2016-08-25 11:27:50 UTC
(In reply to Tony Asleson from comment #2)
> The introspection actually is showing a 'y' == byte.  Unfortunately the
> python dbus library is picking the most appropriate type based on the value.
Exactly, it for example returns '1' as "i" (i.e. INT32).

> In some cases the value is faked because we don't have something returned
> from lvm and in other cases it's the actual value.
Understood.

> 
> I will change it to always return a double.
Thanks!

Comment 5 Vratislav Podzimek 2016-08-31 06:28:28 UTC
(In reply to Tony Asleson from comment #4)
> Fixed upstream
> 
> https://lists.fedorahosted.org/archives/list/lvm2-commits@lists.fedorahosted.
> org/thread/FFQPGS5JEYRZH3GA3HXXQ45CPUMLPTC4/

Looks good to me, thanks!