Bug 1369923

Summary: Planes not displayed on the map
Product: [Fedora] Fedora Reporter: Zbigniew Halas <bugtrackers>
Component: gr-air-modesAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: gmarr, jskarvad
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gr-air-modes-0-0.50.20160831git3bad1f5d.fc25 gr-air-modes-0-0.50.20160831git3bad1f5d.fc24 gr-air-modes-0-0.50.20160831git3bad1f5d.fc23 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-15 18:41:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zbigniew Halas 2016-08-24 18:02:31 UTC 
Description of problem: Planes are not visible in the map tab


Version-Release number of selected component (if applicable): 0.43.20160106git514414f6.fc23


How reproducible: Always


Steps to Reproduce:
1. Launch modes_gui in a terminal
2. Switch to the map tab


Actual results:
The map is empty, the following message can be seen in the terminal:
"file:///tmp/mode_s.html line 120: ReferenceError: Can't find variable: MarkerWithLabel"


Expected results:
Plane icons are visible on the map.


Additional info:
This happens because Google now requires an API key and has been fixed upstream:
https://github.com/bistromath/gr-air-modes/issues/83
This issue will also affect packages for F24 and F25 as they are built from the same git hash.
Comment 1 Jaroslav Škarvada 2016-08-26 11:21:29 UTC 
Thanks for the report I am going to rebase it soon.
Comment 2 Fedora Update System 2016-08-31 14:43:45 UTC 
gr-air-modes-0-0.49.20160831git3bad1f5d.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-33a361c9b9
Comment 3 Fedora Update System 2016-08-31 15:08:31 UTC 
gr-air-modes-0-0.49.20160831git3bad1f5d.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-856f6c8cb5
Comment 4 Fedora Update System 2016-08-31 15:11:30 UTC 
gr-air-modes-0-0.49.20160831git3bad1f5d.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8d5e9a9a9a
Comment 5 Geoffrey Marr 2016-08-31 19:37:21 UTC 
Tested the above update today based on the most recent gr-air-modes code. 'modes_gui' will not launch from the command line and the code must be edited to get the program to successfully launch. However, if this fix is manually added, the planes do correctly show on the map. See the link below [1] for the fix on the official github page.

https://github.com/bistromath/gr-air-modes/issues/87
Comment 6 Jaroslav Škarvada 2016-09-01 09:47:07 UTC 
(In reply to Geoffrey Marr from comment #5)
> Tested the above update today based on the most recent gr-air-modes code.
> 'modes_gui' will not launch from the command line and the code must be
> edited to get the program to successfully launch. However, if this fix is
> manually added, the planes do correctly show on the map. See the link below
> [1] for the fix on the official github page.
> 
> https://github.com/bistromath/gr-air-modes/issues/87

Thanks for testing, I think you should open new downstream bug for it, but no problem, I will resolve itb together with this ticket.
Comment 7 Geoffrey Marr 2016-09-01 14:57:09 UTC 
Jaroslav, I submitted a pull request to the owner of gr-air-modes with the fix [1], hopefully it gets merged soon... I will open a bug if the code isn't merged within the next couple of days.

[1] https://github.com/bistromath/gr-air-modes/pull/88
Comment 8 Jaroslav Škarvada 2016-09-01 15:17:47 UTC 
(In reply to Geoffrey Marr from comment #7)
> Jaroslav, I submitted a pull request to the owner of gr-air-modes with the
> fix [1], hopefully it gets merged soon... I will open a bug if the code
> isn't merged within the next couple of days.
> 
> [1] https://github.com/bistromath/gr-air-modes/pull/88

Thanks for the patch.
Comment 9 Fedora Update System 2016-09-01 16:06:15 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-15c40648d5
Comment 10 Fedora Update System 2016-09-01 16:07:03 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1683b8639
Comment 11 Fedora Update System 2016-09-01 16:13:25 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-86e9007960
Comment 12 Fedora Update System 2016-09-01 19:52:54 UTC 
gr-air-modes-0-0.49.20160831git3bad1f5d.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-856f6c8cb5
Comment 13 Fedora Update System 2016-09-01 20:22:14 UTC 
gr-air-modes-0-0.49.20160831git3bad1f5d.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8d5e9a9a9a
Comment 14 Fedora Update System 2016-09-01 20:24:23 UTC 
gr-air-modes-0-0.49.20160831git3bad1f5d.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-33a361c9b9
Comment 15 Fedora Update System 2016-09-03 03:24:25 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1683b8639
Comment 16 Fedora Update System 2016-09-03 03:53:34 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-86e9007960
Comment 17 Fedora Update System 2016-09-03 03:54:41 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-15c40648d5
Comment 18 Fedora Update System 2016-09-15 18:41:14 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 19 Fedora Update System 2016-09-16 23:21:24 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
Comment 20 Fedora Update System 2016-09-17 19:20:16 UTC 
gr-air-modes-0-0.50.20160831git3bad1f5d.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.