Bug 1369942

Summary: Remove LSM auto-generated snapshot if the VM powered-off during LSM
Product: [oVirt] ovirt-engine Reporter: Ala Hino <ahino>
Component: BLL.StorageAssignee: Benny Zlotnik <bzlotnik>
Status: CLOSED CURRENTRELEASE QA Contact: Yosi Ben Shimon <ybenshim>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0.2.6CC: aefrat, bugs, ebenahar, frolland
Target Milestone: ovirt-4.4.0Flags: aoconnor: ovirt-4.4+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-20 20:02:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1246114    
Bug Blocks:    

Description Ala Hino 2016-08-24 20:18:01 UTC
Description of problem:

Currently, if the VM powered-off during LSM, the auto-generated snapshot is not removed. 
The auto-generated snapshot is not removed because removing it while the VM is not running ends up with cold merge. Until BZ 1246114 isn't resolved, cold merge copies data from base volume to top and this is not desired behavior during LSM.

How reproducible:
100%

Steps to Reproduce:
1. creat a VM with 1gb disk
2. start the VM
3. move the disk
4. power-off the VM *during* LSM

Actual results:
Auto-generated snapshot isn't removed

Expected results:
Auto-generated snapshot to be removed

Additional info:

Comment 1 Red Hat Bugzilla Rules Engine 2016-08-24 20:19:16 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 2 Red Hat Bugzilla Rules Engine 2016-08-24 20:20:45 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 3 Sandro Bonazzola 2019-01-28 09:36:59 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 4 Benny Zlotnik 2019-05-29 08:38:28 UTC
This was fixed as part of bug 1702597

Comment 5 Yosi Ben Shimon 2019-12-22 14:52:28 UTC
Tested on:
ovirt-engine-4.4.0-0.13.master.el7.noarch

The auto-generated snapshot was removed after the LSM failure as expected.

Moving to VERIFIED

Comment 6 Sandro Bonazzola 2020-05-20 20:02:51 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.