Bug 1370101

Summary:	RefreshLunsSizeCommand doesn't update the new LUNs' sizes in the DB
Product:	[oVirt] ovirt-engine	Reporter:	Idan Shaby <ishaby>
Component:	BLL.Storage	Assignee:	Idan Shaby <ishaby>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kevin Alon Goldblatt <kgoldbla>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.0.0	CC:	amureini, bugs, frolland, ishaby
Target Milestone:	ovirt-4.0.4	Flags:	amureini: ovirt-4.0.z? rule-engine: planning_ack? amureini: devel_ack+ rule-engine: testing_ack+
Target Release:	4.0.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:	Previously, after resizing a lun, checking the storage domain's size gave us the new value, but checking the lun's size gave us the old one. This bug was fixed and now the new size is immediately updated, so checking it right after the resize brings the updated value.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-26 12:42:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Idan Shaby 2016-08-25 10:28:07 UTC

Description of problem:
When resizing a LUN, RefreshLunsSizeCommand updates the storage domain's new size but doesn't update the storage domain's LUNs' new sizes in the DB.

Version-Release number of selected component (if applicable):
a58290fe513ffc1c879e984ed746667319ede8ba

How reproducible:
100%

Steps to Reproduce:
1. Create an iSCSI storage domain.
2. Resize the underlying lun(s) of that domain in the storage server.
3. Edit the storage domain in the web admin, go to "LUNs > Targets" and resize the lun(s).

Actual results:
The resize works - the PVs are resized and the storage domain's size is updated.
However, the LUNs in the DB are not updated so their sizes are not up to date.

Expected results:
The LUNs in the DB should be updated and contain their new sizes.

Comment 1 Allon Mureinik 2016-08-31 15:58:16 UTC

Idan - please add some doctext on this issue.

Comment 2 Kevin Alon Goldblatt 2016-09-13 16:57:21 UTC

(In reply to Idan Shaby from comment #0)
> Description of problem:
> When resizing a LUN, RefreshLunsSizeCommand updates the storage domain's new
> size but doesn't update the storage domain's LUNs' new sizes in the DB.
> 
> Version-Release number of selected component (if applicable):
> a58290fe513ffc1c879e984ed746667319ede8ba
> 
> How reproducible:
> 100%
> 
> Steps to Reproduce:
> 1. Create an iSCSI storage domain.
> 2. Resize the underlying lun(s) of that domain in the storage server.
> 3. Edit the storage domain in the web admin, go to "LUNs > Targets" and
> resize the lun(s).


At this point according to the above scenario the additional size added to the LUN is displayed as a text button in the "LUNs > Targets" tab >>>> HOWEVER nothing happens when pressing this button and no resizing is performed. Please clarify whether the LUN resize should be performed by pressing the additional size added with the text "+10 GB"




> 
> Actual results:
> The resize works - the PVs are resized and the storage domain's size is
> updated.
> However, the LUNs in the DB are not updated so their sizes are not up to
> date.
> 
> Expected results:
> The LUNs in the DB should be updated and contain their new sizes.

Comment 3 Idan Shaby 2016-09-14 05:44:10 UTC

(In reply to Kevin Alon Goldblatt from comment #2)
> (In reply to Idan Shaby from comment #0)
> > Description of problem:
> > When resizing a LUN, RefreshLunsSizeCommand updates the storage domain's new
> > size but doesn't update the storage domain's LUNs' new sizes in the DB.
> > 
> > Version-Release number of selected component (if applicable):
> > a58290fe513ffc1c879e984ed746667319ede8ba
> > 
> > How reproducible:
> > 100%
> > 
> > Steps to Reproduce:
> > 1. Create an iSCSI storage domain.
> > 2. Resize the underlying lun(s) of that domain in the storage server.
> > 3. Edit the storage domain in the web admin, go to "LUNs > Targets" and
> > resize the lun(s).
> 
> 
> At this point according to the above scenario the additional size added to
> the LUN is displayed as a text button in the "LUNs > Targets" tab >>>>
> HOWEVER nothing happens when pressing this button and no resizing is
> performed. Please clarify whether the LUN resize should be performed by
> pressing the additional size added with the text "+10 GB"
You should press that button and then click on the "OK" button.
> 
> 
> 
> 
> > 
> > Actual results:
> > The resize works - the PVs are resized and the storage domain's size is
> > updated.
> > However, the LUNs in the DB are not updated so their sizes are not up to
> > date.
> > 
> > Expected results:
> > The LUNs in the DB should be updated and contain their new sizes.

Comment 4 Kevin Alon Goldblatt 2016-09-14 14:48:30 UTC

Tested with the following code:
----------------------------------------
rhevm-4.0.4.2-0.1.el7ev.noarch
vdsm-4.18.13-1.el7ev.x86_64

Tested with the following scenario:

Steps to Reproduce:
1. Create an iSCSI storage domain.
2. Resize the underlying lun(s) of that domain in the storage server.
3. Edit the storage domain in the web admin, go to "LUNs > Targets" and resize the lun(s) >>>>> The resize operation is successful and the DB is correctly updated.

Actual results:
The resize works - the PVs are resized and the storage domain's size is updated.
The LUNs in the DB ARE NOW updated so their sizes ARE up to date.

Expected results:
The LUNs in the DB should be updated and contain their new sizes.


Moving to VERIFIED!